Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab switch looks slow? #9006

Closed
ThomsonTan opened this issue Feb 2, 2021 · 15 comments
Closed

Tab switch looks slow? #9006

ThomsonTan opened this issue Feb 2, 2021 · 15 comments
Labels
Area-Performance Performance-related issue Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Milestone

Comments

@ThomsonTan
Copy link

Environment

Windows build number: 10.0.19042.746
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

Press ctrl+tab to switch tabs, it shows a drop list of tabs, then switch to the next tab.

Expected behavior

The switch should be down immediately if I press ctrl+tab and release the keys immediately.

Actual behavior

But it seems taking almost 1 sec to complete the switch, this sluggish could be very annoy if I want to switch to the next tab for some peeking and switch back.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 2, 2021
@Don-Vito
Copy link
Contributor

Don-Vito commented Feb 2, 2021

@ThomsonTan

  1. What version of terminal are you using?
  2. Does the sluggishness start immediately or after running the Terminal for a while?
  3. How many tabs are open?

@ThomsonTan
Copy link
Author

ThomsonTan commented Feb 2, 2021

  1. The version string is Microsoft.WindowsTerminalPreview_1.4.2652.0_x64.
  2. I am not sure it start immediately after launch. I just tried launching a separate instance of wt.exe, also with 4 tabs, seems the switching if very fluent.
  3. 4 tabs, starts from powershell, but I launched python under cmd.exe within the powershell tab.

@Don-Vito
Copy link
Contributor

Don-Vito commented Feb 2, 2021

Asking this because there are several very similar discussions, around tab switching and drop-down menu becoming sluggish after some time: #7710 (and #8702 that was closed as duplicate)

@Don-Vito
Copy link
Contributor

Don-Vito commented Feb 2, 2021

Also in 1.4 there was some slowness that was related to the amount of tabs (solved in 1.5) but it might be irrelevant if it happens to you with a small amount of tabs as well.

@JohnLukeBentley
Copy link

@ThomsonTan have you tried uninstalling Powershell 64 bit and installing Powershell 32 bit (e.g. from https://github.com/PowerShell/PowerShell/releases > Some release > Assests > PowerShell-7.1.1-win-x86.msi)?

@ThomsonTan
Copy link
Author

@JohnLukeBentley I haven't tried 32-bit installer. I'd prefer 64-bit in general, but I could try that if it could help gather data for locating the problem.

@JohnLukeBentley
Copy link

That solved the problem for me (over in #7710 and #3515). And so yes, that would help with locating the problem(s).

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 3, 2021
@zadjii-msft
Copy link
Member

Alright, hopefully it does help. Otherwise, I'd suggest updating the Terminal - preview just got updated to 1.6 a week ago, so it's very possible that this was fixed sometime in the last two releases

@ghost ghost added the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Feb 7, 2021
@ghost
Copy link

ghost commented Feb 7, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@guillebot
Copy link

I have the same problem. Extremely slow switching tabs either via ctrl+tab or mouse click.

@ghost ghost removed the No-Recent-Activity This issue/PR is going stale and may be auto-closed without further activity. label Feb 9, 2021
@zadjii-msft
Copy link
Member

zadjii-msft commented Feb 10, 2021

You know what, this seems to be happening to me too (on preview 1.6.10272.0). I thought it was just my slaptop chugging because I was building at first, but now I don't think there's anything else running that should cause such a delay.

Weirdly though, it doesn't happen on fresh terminal windows. It's only happening on my primary on that I've been using for a few days. There's nothing weird about it in Task Manager - CPU, memory, GPU all look like they're in reasonable limits. But tab switching (via clicking AND via the ATS), tab creating, pane splitting are all laggy. The command palette takes a while to appear, and long to repopulate when starting to type in it. Heck, even just navigating the new tab dropdown with the arrow keys seems particularly un-responsive.

I'll keep my eye on this one. Maybe over the course of 1.7 we'll have a better idea of what's going on. Maybe I'll get a consistent repro. If anyone has any thoughts, or wants to profile their terminal and figure it out, I'm all ears.

@zadjii-msft zadjii-msft added Area-Performance Performance-related issue Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 10, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 10, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.7 milestone Feb 10, 2021
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Feb 10, 2021
@guillebot
Copy link

You know what, this seems to be happening to me too (on preview 1.6.10272.0). I thought it was just my slaptop chugging because I was building at first, but now I don't think there's anything else running that should cause such a delay.

Weirdly though, it doesn't happen on fresh terminal windows. It's only happening on my primary on that I've been using for a few days. There's nothing weird about it in Task Manager - CPU, memory, GPU all look like they're in reasonable limits. But tab switching (via clicking AND via the ATS), tab creating, pane splitting are all laggy. The command palette takes a while to appear, and long to repopulate when starting to type in it. Heck, even just navigating the new tab dropdown with the arrow keys seems particularly un-responsive.

I'll keep my eye on this one. Maybe over the course of 1.7 we'll have a better idea of what's going on. Maybe I'll get a consistent repro. If anyone has any thoughts, or wants to profile their terminal and figure it out, I'm all ears.

My PC is quite powerfull, its an i9-10900 with 64GB RAM and NVME disks. Everything seems to fly but this terminal. There is definitely some problem here.

It's a shame because it is the best terminal I've ever tried for windows, it replicates a lot of nice features I'm used to use in the *nix world.

@guillebot
Copy link

Preview seems to do much better!

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 12, 2021
@zadjii-msft
Copy link
Member

You know what, in retrospect, this seems similar enough to #7710 that I'm gonna close this as a dupe to try and keep the discussion contained. Thanks!

/dup #7710

@ghost
Copy link

ghost commented Feb 25, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Feb 25, 2021
@ghost ghost added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Feb 25, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Performance Performance-related issue Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

6 participants