Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enable pixel shaders #9071

Closed
bozho opened this issue Feb 8, 2021 · 7 comments
Closed

Cannot enable pixel shaders #9071

bozho opened this issue Feb 8, 2021 · 7 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Question For questions or discussion Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered

Comments

@bozho
Copy link

bozho commented Feb 8, 2021

Environment

Windows build number: Microsoft Windows NT 10.0.19042.0
Windows Terminal version (if applicable): 1.6.10272.0

GPU: Nvidia RTX 3070, driver version 461.40.

Steps to reproduce

I am unable to get pixel shaders working. I've downloaded a few samples (retro, invert, rasterbars) and put them into F:\Temp

I've tried putting "experimental.pixelShaderEffect": "F:\\Temp\\invert.hlsl" into both profile defaults and individual profiles. I've added { "command": "toggleShaderEffects", "keys": "ctrl+shift+."} to actions. The only thing this command seem to do is toggle the built-in "retro" effect (whether experimental.pixelShaderEffect setting is present or not makes no difference).

I've renamed my settings.json file and tested with a default one, no difference.

Expected behavior

Shaders to work :-)

Actual behavior

Shaders not working :-(

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 8, 2021
@zadjii-msft
Copy link
Member

The setting is experimental.pixelShaderPath, not experimental.pixelShaderEffect ☺️

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Question For questions or discussion Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered labels Feb 8, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 8, 2021
@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 8, 2021
@DHowett DHowett closed this as completed Feb 8, 2021
@bozho
Copy link
Author

bozho commented Feb 8, 2021

@zadjii-msft

Ah, thank you :-) experimental.pixelShaderPath is mentioned in pixel shader samples.

However, experimental.pixelShaderEffect is mentioned both on 1.6.10272.0 release notes page and devblog page. I copy/pasted the setting from one of those two and failed to spot the difference.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Feb 8, 2021
@zadjii-msft
Copy link
Member

GAH that's a typo then. @cinnamon-msft can you go fix those docs quick?

@DHowett
Copy link
Member

DHowett commented Feb 8, 2021

I've fixed the release notes. Sorry about that!

@sylvain69780
Copy link

Hello

I just downloaded 1.7.572.0 and was not able to enable "experimental.pixelShaderPath".
"experimental.pixelShaderPath": "C:\Sylvain\shadertoy\hlsl\Grayscale.hlsl"

Only able to use the retroTerminalEffect.

I wanted to make a demo to some colleagues. Too bad. :-)

@zadjii-msft
Copy link
Member

@sylvain69780 Did it give you any sort of error message when you changed the settings / launched the Terminal?

You might also need to use double-backslashes, like "experimental.pixelShaderPath": "C:\\Sylvain\\shadertoy\\hlsl\\Grayscale.hlsl"

@DHowett
Copy link
Member

DHowett commented Mar 16, 2021

This is #9354.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Question For questions or discussion Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

4 participants