Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to differentiate active/inactive dark theme tabs #9173

Closed
trajano opened this issue Feb 15, 2021 · 3 comments
Closed

Hard to differentiate active/inactive dark theme tabs #9173

trajano opened this issue Feb 15, 2021 · 3 comments
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@trajano
Copy link

trajano commented Feb 15, 2021

I only have a few tab based apps, namely the browsers, text editor and Windows Terminal. However, the way they render tabs specifically the colors differ and it's not really usable in Windows Terminal

Environment

Windows build number: Microsoft Windows [Version 10.0.19042.804]
Windows Terminal version (if applicable): Version: 1.5.10411.0

Edge
Firefox

Steps to reproduce

Use Dark Mode in system settings
Set accent color
image

Open multiple tabs

Expected behavior

Color consistency between tabs on the app

Edge accent color is blue and the active tab is black so it's distinguishable.

image

Firefox looks similar I like the bar on top but I guess that's a custom firefox implementation HHowever it still takes the accent color correctly.

image

Actual behavior

The dark mode tabs are hard to distinguish in Terminal when active.

image

Light mode is at least distinguishable.

image

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 15, 2021
@DHowett
Copy link
Member

DHowett commented Feb 15, 2021

I think we have an issue for this sitting around somewhere, but I am worried that you have a display contrast issue. The contrast ratio for the dark theme in your screenshots is 1.66:1, and the contrast ratio for the light theme is 1.6:1. They're very much extremely the same distinction between selected/unselected.

You might be interested in #3327, which would let you specify that the titlebar have an accent color background (like Firefox in your screenshot above.)

@DHowett
Copy link
Member

DHowett commented Feb 15, 2021

/dup #1963 specifically!

@ghost
Copy link

ghost commented Feb 15, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Feb 15, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 15, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants