Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected renderer error occurred after specifying pixel shader path. #9338

Closed
lgx98 opened this issue Mar 2, 2021 · 8 comments
Closed
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.

Comments

@lgx98
Copy link

lgx98 commented Mar 2, 2021

Environment

Windows build number: 10.0.19042.0
Windows Terminal version (if applicable): 1.6.10571.0

Any other software?
* Cascadia Code
* Cascadia Code PL
* Cascadia Mono
* Cascadia Mono PL

Steps to reproduce

I had a fresh new Windows Terminal install from Microsoft Store;

downloaded example shaders from here;

added the following line to "Windows PowerShell" profile in settings.json and saved changes to file;

"experimental.pixelShaderPath": "‪‪D:\\temp\\Invert.hlsl",

restarted Windows Terminal and a warning popped up:
image
which translates to:

Warning
Renderer encountered an unexpected error: -2147024773
[OK]

And I think this warning message comes from this line.

I also tried changing the path to ‪D:/temp/Invert.hlsl; changing the path to an empty folder; adding obvious syntax errors to the hlsl file.
But nothing changed, every time the exact same warning message popped up.

Expected behavior

Nothing pops up and the screen color is inverted.

Actual behavior

Described above.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 2, 2021
@zadjii-msft
Copy link
Member

Weird, that error is:

ERROR_INVALID_NAME The filename, directory name, or volume label syntax is incorrect. winerror.h

Which I don't think makes any sense. Does the retro terminal effect work for you? Use "experimental.retroTerminalEffect": true instead of experimental.pixelShaderPath

@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Priority-3 A description (P3) labels Mar 2, 2021
@lgx98
Copy link
Author

lgx98 commented Mar 3, 2021

"experimental.retroTerminalEffect": true works fine.

image

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 3, 2021
@lgx98
Copy link
Author

lgx98 commented Mar 3, 2021

After trying "‪‪D:\temp\Invert.hlsl", "‪‪D:\temp\\Invert.hlsl" , "‪‪D:\\temp\Invert.hlsl" and several other strings, I somehow managed to "glitch" it and made it work properly with shader files under ‪‪D:\temp\.

image

However, when I changed the path from D:\temp\ to C:\Users\{Username}\temp\, the same warning message popped up just like before. (these two folders contain the same files)

image

Then I restarted Windows Terminal; changed path to other shader files in the same folder; tried to "glitch" again. But nothing new happened.

@zadjii-msft
Copy link
Member

Hey so, I know you've gone through the trouble of hiding your Windows username in your screenshots, but I'm worried now if that might be part of the problem. Does your username have any Chinese characters in it? I'm worried that the shader might fail to load if the path has non-ascii characters in it. If you don't want to share your username, could you try some other path with Chinese characters in it?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Mar 3, 2021
@lgx98
Copy link
Author

lgx98 commented Mar 3, 2021

Hey so, I know you've gone through the trouble of hiding your Windows username in your screenshots, but I'm worried now if that might be part of the problem. Does your username have any Chinese characters in it? I'm worried that the shader might fail to load if the path has non-ascii characters in it. If you don't want to share your username, could you try some other path with Chinese characters in it?

No, my username is made up of English letters and number digits. It's even a valid variable name in C/C++.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 3, 2021
@zadjii-msft
Copy link
Member

Huh. Well there goes that theory. Here's another totally wild theory - does the drive matter? Can the Terminal consistently load shaders from the D:\ drive, but not the C:\ drive?

@zadjii-msft zadjii-msft added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Mar 3, 2021
@lgx98
Copy link
Author

lgx98 commented Mar 4, 2021

Everything is working perfectly today. I've tried both drives, path with Chinese characters, inside and outside $HOME.

But I have no idea on what caused this change. Basically I was browsing the Internet and making PowerPoints these days. There was neither system update, nor Windows Terminal Update.😂

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 4, 2021
@zadjii-msft
Copy link
Member

Well. That's annoying that the repro is gone before we could figure it out. But I'm glad that it's fixed! I still have no idea what might have caused this. I suppose I'll keep my eyes open for future reports.

Thanks!

@zadjii-msft zadjii-msft added the Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely. label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Resolution-No-Repro We couldn't get this to happen, or it stopped happening entirely.
Projects
None yet
Development

No branches or pull requests

2 participants