From e3be862f63910b57380295b0227ebf5cea5c5c4f Mon Sep 17 00:00:00 2001 From: khvitaly Date: Fri, 18 Dec 2020 02:45:27 +0200 Subject: [PATCH] Prevent tab icon blinking upon tab gaining focus --- src/cascadia/TerminalApp/TerminalTab.cpp | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/cascadia/TerminalApp/TerminalTab.cpp b/src/cascadia/TerminalApp/TerminalTab.cpp index ff2c62e029e..277943c13a4 100644 --- a/src/cascadia/TerminalApp/TerminalTab.cpp +++ b/src/cascadia/TerminalApp/TerminalTab.cpp @@ -219,17 +219,19 @@ namespace winrt::TerminalApp::implementation if (auto tab{ weakThis.get() }) { - if (hide) + if (tab->_iconHidden != hide) { - Icon({}); - TabViewItem().IconSource(IconPathConverter::IconSourceMUX({})); - tab->_iconHidden = true; - } - else - { - Icon(_lastIconPath); - TabViewItem().IconSource(IconPathConverter::IconSourceMUX(_lastIconPath)); - tab->_iconHidden = false; + if (hide) + { + Icon({}); + TabViewItem().IconSource(IconPathConverter::IconSourceMUX({})); + } + else + { + Icon(_lastIconPath); + TabViewItem().IconSource(IconPathConverter::IconSourceMUX(_lastIconPath)); + } + tab->_iconHidden = hide; } } }