Add support to manage Teams in Projects #121

tmeckel · 2020-08-01T15:46:05Z

All Submissions:

Have you added an explanation of what your changes do and why you'd like us to include them?
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.
My code follows the code style of this project.
I ran lint checks locally prior to submission.
Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

This pull request contains the following new resources:

azuredevops_team - for managing a Team
azuredevops_team_members - for managing members of a team
azuredevops_team_administrators - for managing administrators of a team

This pull request contains the following new data sources:

azuredevops_team - to load information about a Team inside a Project in Azure DevOps
azuredevops_teams - to load all Teams defined in a a Project in Azure DevOps or all (accessible) Teams of all (accessible) Projects

Does this introduce a change to `go.mod`, `go.sum` or `vendor/`?

Yes
No

Does this introduce a breaking change?

Yes
No

Any relevant logs, error output, etc?

N/A

Other information

#343

tmeckel · 2021-05-05T17:48:56Z

@xuzhang3 finally I found some time to finish up the PR. Ready for review

tmeckel · 2021-05-05T18:25:07Z

There is an issue with the tfproviderdocs tool

Therefore the pipeline is failing at an early state. I can reproduce the error locally. So I guess the repo is kinda broken. @xuzhang3 shouldn't we not pin the tools which got installed with GNUmakefile to a specific version`?

copy @bflad and @katbyte for reference

xuzhang3 · 2021-05-07T08:18:04Z

Hi @tmeckel Fixed and merged, please update the latest code.

tmeckel · 2021-05-07T09:46:55Z

@xuzhang3 will rebase the PR later today

xuzhang3 · 2021-05-08T07:44:52Z

@tmeckel I have reverted the SDK upgrade. Current master code is based on v0.1.4, the tools install issue has been fixed in PR #376 . Sorry for the inconvenient.

tmeckel · 2021-05-08T10:07:20Z

@xuzhang3 No worries! Thanks for having the issues sorted and fixed! 👍🏼 👍🏼

tmeckel · 2021-05-21T07:16:08Z

@xuzhang3 ping! 😀

xuzhang3 · 2021-05-21T09:00:24Z

Hi @tmeckel I will review this PR next week!

…azuredevops_team_administrators and azuredevops_team

…issions/utils/namespaces.go

…redevops/internal/service/permissions/utils/namespaces_test.go

… empty or nil instead of returning an error in azuredevops/internal/service/permissions/utils/namespaces.go

…/core/resource_team.go

…issions/utils/namespaces.go

xuzhang3 · 2021-05-24T07:13:36Z

@xuzhang3 while debugging the acceptance test I came across the infamous '<' looking for beginning of value error again! I guess we have a real issue here! Really sucks to debug, because it only shows up intermittently!

This error not always happen. A potential error is service returned the response as HTML(PAT expires or other errors), the client.UnmarshalCollectionJson cannot marshal the response object and return the parse error.

An error example:

func main() {
	var responseValue []build.DefinitionResourceReference
	err := json.Unmarshal([]byte("<html></html>"), &responseValue)
	fmt.Println(err)
}

Result:
invalid character '<' looking for beginning of value

azuredevops/internal/service/core/resource_team.go

azuredevops/internal/acceptancetests/resource_team_test.go

website/docs/d/data_team.html.markdown

website/docs/r/team.html.markdown

website/docs/d/data_teams.html.markdown

Co-authored-by: xuzhang3 <[email protected]>

…stutils/hcl.go

…ues are consistently available from the REST API after creation and updates

…esourceTeam

tmeckel · 2021-05-26T17:26:05Z

@xuzhang3 I overhauled the code a bit 😀 ready for next review!

…n azuredevops/internal/service/core/resource_team.go

tmeckel · 2021-08-09T20:02:00Z

@xuzhang3 ping ❤️

xuzhang3 · 2021-08-10T02:19:07Z

@tmeckel can you help resolve the conflicting files: azuredevops/provider.go

# Conflicts: # azuredevops/provider.go

xuzhang3 · 2021-08-13T03:10:01Z

LGTM

ghost added size/XL documentation labels Aug 1, 2020

tmeckel force-pushed the r_teams branch 2 times, most recently from cbdd6ad to 8fd6bcf Compare August 17, 2020 08:56

tmeckel force-pushed the r_teams branch 2 times, most recently from ec3560d to f520c55 Compare May 5, 2021 16:10

tmeckel marked this pull request as ready for review May 5, 2021 17:47

tmeckel changed the title ~~[WIP] Adding support to manage Teams in Projects~~ Adding support to manage Teams in Projects May 5, 2021

tmeckel force-pushed the r_teams branch from 95be6e2 to 89a4b24 Compare May 7, 2021 10:35

xuzhang3 force-pushed the master branch from fb0c2ca to d80cc6d Compare May 8, 2021 07:29

tmeckel force-pushed the r_teams branch from f31de0c to d95f64c Compare May 8, 2021 10:05

tmeckel mentioned this pull request May 8, 2021

Teams support #343

Closed

tmeckel added 10 commits May 21, 2021 18:11

Added skelaton files for azuredevops_team, azuredevops_team_members, …

1e936d2

…azuredevops_team_administrators and azuredevops_team

Made GetAccessControlList public in azuredevops/internal/service/perm…

cab15c5

…issions/utils/namespaces.go

Implemented data source azuredevops_team

fdb1320

Implemented integration test for data source azuredevops_team

36972d6

First implementation of resource azuredevops_team

39610a2

Corrected unit tests for security namespace beacuse of f9e2b78 in azu…

2eee552

…redevops/internal/service/permissions/utils/namespaces_test.go

SetPrincipalPermissions skips processing now if the permissionList is…

8056178

… empty or nil instead of returning an error in azuredevops/internal/service/permissions/utils/namespaces.go

First working version of ResourceTeam in azuredevops/internal/service…

e22ea93

…/core/resource_team.go

Made GetActionDefinitions public in azuredevops/internal/service/perm…

41e070d

…issions/utils/namespaces.go

First complete working version of Teams support

80f9f0d

xuzhang3 self-assigned this May 24, 2021

xuzhang3 added new-data-source new-feature new-resource labels May 24, 2021

xuzhang3 requested changes May 26, 2021

View reviewed changes

tmeckel and others added 10 commits May 26, 2021 10:54

Update website/docs/r/team_administrators.html.markdown

76de206

Co-authored-by: xuzhang3 <[email protected]>

Update website/docs/d/data_teams.html.markdown

3de5580

Co-authored-by: xuzhang3 <[email protected]>

Update website/docs/r/team.html.markdown

06c0a92

Co-authored-by: xuzhang3 <[email protected]>

added HclTeamConfiguration to azuredevops/internal/acceptancetests/te…

719c23b

…stutils/hcl.go

ResourceTeam now utilizes stateConf.WaitForState() to ensure that val…

3d47af9

…ues are consistently available from the REST API after creation and updates

added additonal stateConf.WaitForState() calls to ResourceTeamMembers

5c7ce54

Updated documentation according to review

f3a55c9

DataTeam now uses an explicit schema instead of derived schema from R…

432804b

…esourceTeam

Updated acceptance tests

9de9e3c

Fixed linting errors

eeac463

tmeckel requested a review from xuzhang3 May 26, 2021 17:26

tmeckel changed the title ~~Adding support to manage Teams in Projects~~ Add support to manage Teams in Projects May 26, 2021

xuzhang3 and others added 2 commits May 31, 2021 17:25

hcl format

ba78439

Added StringLenBetween validation to description property of a Team i…

440de9c

…n azuredevops/internal/service/core/resource_team.go

xuzhang3 added 3 commits August 12, 2021 16:15

Merge remote-tracking branch 'upstream/master' into r_teams

8e483e8

# Conflicts: # azuredevops/provider.go

doc update

99ab06c

resolve conflict files

1834fcb

xuzhang3 approved these changes Aug 13, 2021

View reviewed changes

xuzhang3 merged commit 8bd5fb5 into microsoft:master Aug 13, 2021

tmeckel deleted the r_teams branch November 13, 2021 14:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to manage Teams in Projects #121

Add support to manage Teams in Projects #121

tmeckel commented Aug 1, 2020 •

edited

Loading

tmeckel commented May 5, 2021

tmeckel commented May 5, 2021 •

edited

Loading

xuzhang3 commented May 7, 2021 •

edited

Loading

tmeckel commented May 7, 2021

xuzhang3 commented May 8, 2021

tmeckel commented May 8, 2021

tmeckel commented May 21, 2021

xuzhang3 commented May 21, 2021

xuzhang3 commented May 24, 2021

tmeckel commented May 26, 2021

tmeckel commented Aug 9, 2021

xuzhang3 commented Aug 10, 2021

xuzhang3 commented Aug 13, 2021

Add support to manage Teams in Projects #121

Add support to manage Teams in Projects #121

Conversation

tmeckel commented Aug 1, 2020 • edited Loading

All Submissions:

What about the current behavior has changed?

Does this introduce a change to go.mod, go.sum or vendor/?

Does this introduce a breaking change?

Any relevant logs, error output, etc?

Other information

tmeckel commented May 5, 2021

tmeckel commented May 5, 2021 • edited Loading

xuzhang3 commented May 7, 2021 • edited Loading

tmeckel commented May 7, 2021

xuzhang3 commented May 8, 2021

tmeckel commented May 8, 2021

tmeckel commented May 21, 2021

xuzhang3 commented May 21, 2021

xuzhang3 commented May 24, 2021

tmeckel commented May 26, 2021

tmeckel commented Aug 9, 2021

xuzhang3 commented Aug 10, 2021

xuzhang3 commented Aug 13, 2021

tmeckel commented Aug 1, 2020 •

edited

Loading

Does this introduce a change to `go.mod`, `go.sum` or `vendor/`?

tmeckel commented May 5, 2021 •

edited

Loading

xuzhang3 commented May 7, 2021 •

edited

Loading