azuredevops additional branch policy settings in the terraform provider

[billbirchatcoles]

This PR is to add new kinds of permissions to the branch policies.

• submitter_can_vote - (Optional) Allow requestors to approve their own changes. Defaults to false.
• last_pusher_cannot_approve(Optional) Prohibit the most recent pusher from approving their own changes. Defaults to false.
• allow_completion_with_rejects_or_waits (Optional) Allow completion even if some reviewers vote to wait or reject. Defaults to false.
• on_push_reset_approved_votes (Optional) When new changes are pushed reset all approval votes (does not reset votes to reject or wait). Defaults to false.
• on_push_reset_all_votes (Optional) When new changes are pushed reset all code reviewer votes. Defaults to false.
• on_last_iteration_require_vote (Optional) On last iteration require vote. Defaults to false.

All Submissions:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• My code follows the code style of this project.
• I ran lint checks locally prior to submission.
• Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

No changes

Issue Number: #206

Does this introduce a change to go.mod, go.sum or vendor/?

• Yes
• No

Does this introduce a breaking change?

• Yes
• No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

[ghost]

All CLA requirements met.

[xuzhang3]

@billbirchatcoles azuredevops_branch_policy_auto_reviewers document not updated.

[xuzhang3]

Since flag was duplicate for 6 times, suggest change to

settings := fmt.Sprintf(
		`
		reviewer_count     = %[1]d
		submitter_can_vote = %[2]t
		allow_completion_with_rejects_or_waits = %[2]t
		last_pusher_cannot_approve = %[2]t
		on_last_iteration_require_vote = %[2]t
		on_push_reset_all_votes = %[2]t
		on_push_reset_approved_votes = %[2]t		
		`, reviewers, flag,
	)

[birchb1024]

Done

[xuzhang3]

Only one of on_push_reset_approved_votes and on_push_reset_all_votes can be set to true at the same time. If set them all to true, on_push_reset_all_votes will eventually take effect. Can we add some checks and block the wrong configurations before send request to service?

[birchb1024]

Done

[birchb1024]

Merged in latest master (3bd4c54). Retested.

[birchb1024]

Merged in latest master (76e37e7).

[birchb1024]

Azdo build failed with

=== RUN   TestAccBranchPolicyAutoReviewers_CreateAndUpdate
    testing.go:684: Step 0 error: After applying this step and refreshing, the plan was not empty:

[birchb1024]

Maybe the min-reviewers test has deleted the '[email protected]' account but that is a wild guess. I can't see the test data...

[xuzhang3]

Sometimes the tests is unstable, re-run can handle this.

[xuzhang3]

LGTM