Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable groups dont error if they dont exist #359

Merged
merged 1 commit into from
Apr 15, 2021

Conversation

srbry
Copy link
Contributor

@srbry srbry commented Apr 14, 2021

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

You get a terraform error:

Error: rpc error: code = Unavailable desc = transport is closing

This is because the taskagentClient.GetVariableGroup code does not actually return an error when it can't find a variable group, it just returns an empty VariableGroup object.

This PR checks if the Id returned is nil and treats it the same way as if the expected error was returned

Issue Number:

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@xuzhang3
Copy link
Collaborator

@srbry Thanks for your PR, LGTM

@xuzhang3 xuzhang3 merged commit 3bdbddf into microsoft:master Apr 15, 2021
@srbry
Copy link
Contributor Author

srbry commented Apr 15, 2021

@xuzhang3 thanks for merging this so quickly. Do you have any idea when the next version will get released?

@xuzhang3
Copy link
Collaborator

@srbry v01.4 will be released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants