-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ArgoCD service connections #501
Conversation
We stopped hearing from agent Hosted Agent...
.. Dev container build ... Bash exited with code '1'
The Azure DevOps infrastructure was a bit sick. Third attempt was successful. |
@jaroslav-svoboda Is this new service connection from market place? Can you share the install link? |
Hi @xuzhang3, I have already provided link in Other information section: Adds support for this service extension: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaroslav-svoboda LGTM, a bit change request.
- since this service endpoint is not an official extension, can you add a notice to the doc that user need to install the https://marketplace.visualstudio.com/items?itemName=scb-tomasmortensen.vsix-argocd for their organization before using this resource.
- The
website/docs/r/serviceendpoint_argocd.html.markdown
should add to https://github.com/microsoft/terraform-provider-azuredevops/blob/main/website/azuredevops.erb
|
@xtrasolver I was confused which type of authorization you use. When I create a new ArgoCD service endpoints with the example in the document. The authorization is You can get service endpoint by API:https://dev.azure.com/{organization}/{project}/_apis/serviceendpoint/endpoints/{endpointId}?api-version=6.0-preview.4 |
@xuzhang3 I fixed authentication. Currently it supports both authentication methods. I fetched code from main, so it supports v6 api too. |
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_argocd.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_argocd.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_argocd.go
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_argocd.go
Outdated
Show resolved
Hide resolved
Co-authored-by: xuzhang3 <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
All Submissions:
What about the current behavior has changed?
Add New Resource azuredevops_serviceendpoint_argocd
Issue Number: N/A
Does this introduce a change to
go.mod
,go.sum
orvendor/
?Does this introduce a breaking change?
Any relevant logs, error output, etc?
N/A
Other information
Inspired by Artifactory resources or to be correct based on Artifactory resource.
Adds support for this service extension:
Argo CD Extension for Azure Pipelines