Add tagging permissions #510

martenvd · 2022-01-03T15:25:27Z

All Submissions:

Have you added an explanation of what your changes do and why you'd like us to include them?
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.
My code follows the code style of this project.
I ran lint checks locally prior to submission.
Have you checked to ensure there aren't other open PRs for the same update/change?

Explanation of the changes

My team is currently working on getting all our Azure DevOps permissions in code. This is one of the last permissions that we still only implement with Powershell rather than Terraform. I would love to have all our permissions in Terraform.

What about the current behavior has changed?

Implementing the security permissions for the tagging feature in Azure DevOps.

Does this introduce a change to `go.mod`, `go.sum` or `vendor/`?

Yes
No

Does this introduce a breaking change?

Yes
No

tmeckel · 2022-01-03T16:44:01Z

azuredevops/internal/service/permissions/resource_tagging_permissions.go

+			"project_id": {
+				Type:         schema.TypeString,
+				ValidateFunc: validation.IsUUID,
+				Required:     true,


Can be optional to set global (organization wide) permissions for Tagging

tmeckel · 2022-01-03T16:44:46Z

azuredevops/internal/service/permissions/resource_tagging_permissions.go

+func createTaggingToken(d *schema.ResourceData, clients *client.AggregatedClient) (string, error) {
+	projectID, ok := d.GetOk("project_id")
+	if !ok {
+		return "ProjectID", nil


If project_id is not specified return an empty string "" as token.

tmeckel · 2022-01-03T16:45:42Z

website/docs/r/tagging_permissions.html.markdown

+
+The following arguments are supported:
+
+* `project_id` - (Required) The ID of the project to assign the permissions.


optional: if not set, organization wide permissions for tagging are managed.

tmeckel · 2022-01-03T16:48:24Z

website/docs/r/tagging_permissions.html.markdown

+
+## Permission levels
+
+Permissions for tagging within Azure DevOps can be applied only on Project level.


Can be applied on a specific project and globally on the organization

martenvd · 2022-01-03T17:14:47Z

@tmeckel Thank you for the comments, I have resolved them 😃

xuzhang3 · 2022-01-04T07:20:35Z

azuredevops/internal/acceptancetests/resource_tagging_permissions_test.go

+					resource.TestCheckResourceAttr(tfNodeRoot, "permissions.ViewSubscriptions", "deny"),
+					resource.TestCheckResourceAttr(tfNodeRoot, "permissions.EditSubscriptions", "notset"),
+					resource.TestCheckResourceAttr(tfNodeRoot, "permissions.DeleteSubscriptions", "deny"),
+					resource.TestCheckResourceAttr(tfNodeRoot, "permissions.PublishEvents", "deny"),


Test check does not map the HCl configures above.

@xuzhang3 thank you for reviewing, forgot this copy paste error, but resolved it now.

xuzhang3 · 2022-01-04T08:02:06Z

=== RUN   TestAccTaggingPermissions_SetPermissions
=== PAUSE TestAccTaggingPermissions_SetPermissions
=== RUN   TestAccTaggingPermissions_UpdatePermissions
=== PAUSE TestAccTaggingPermissions_UpdatePermissions
=== CONT  TestAccTaggingPermissions_SetPermissions
=== CONT  TestAccTaggingPermissions_UpdatePermissions
--- PASS: TestAccTaggingPermissions_UpdatePermissions (108.03s)
--- PASS: TestAccTaggingPermissions_SetPermissions (127.20s)
PASS

xuzhang3 · 2022-01-04T08:02:28Z

LGTM

RodrigoGroener · 2022-01-17T13:23:54Z

I've been waiting for the tagging permissions. Thank you for your contribution! When will be the next release of the provider including this feature?

martenvd added 2 commits January 3, 2022 15:59

Create resource tagging permissions

17d9915

tests and docs

45d309c

martenvd changed the title ~~Tag management permissions~~ Tagging permissions Jan 3, 2022

tmeckel suggested changes Jan 3, 2022

View reviewed changes

project_id optional

f8763b7

martenvd changed the title ~~Tagging permissions~~ Add tagging permissions Jan 3, 2022

xuzhang3 added the new-resource label Jan 4, 2022

xuzhang3 requested changes Jan 4, 2022

View reviewed changes

fix copy paste

4cbed0d

xuzhang3 merged commit 43b4b3f into microsoft:main Jan 4, 2022

martenvd deleted the tag-management-permissions branch January 4, 2022 08:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tagging permissions #510

Add tagging permissions #510

martenvd commented Jan 3, 2022 •

edited

Loading

tmeckel Jan 3, 2022

tmeckel Jan 3, 2022

tmeckel Jan 3, 2022

tmeckel Jan 3, 2022

martenvd commented Jan 3, 2022

xuzhang3 Jan 4, 2022

martenvd Jan 4, 2022

xuzhang3 commented Jan 4, 2022

xuzhang3 commented Jan 4, 2022

RodrigoGroener commented Jan 17, 2022 •

edited

Loading


		The following arguments are supported:

		* `project_id` - (Required) The ID of the project to assign the permissions.


		## Permission levels

		Permissions for tagging within Azure DevOps can be applied only on Project level.

Add tagging permissions #510

Add tagging permissions #510

Conversation

martenvd commented Jan 3, 2022 • edited Loading

All Submissions:

Explanation of the changes

What about the current behavior has changed?

Does this introduce a change to go.mod, go.sum or vendor/?

Does this introduce a breaking change?

tmeckel Jan 3, 2022

Choose a reason for hiding this comment

tmeckel Jan 3, 2022

Choose a reason for hiding this comment

tmeckel Jan 3, 2022

Choose a reason for hiding this comment

tmeckel Jan 3, 2022

Choose a reason for hiding this comment

martenvd commented Jan 3, 2022

xuzhang3 Jan 4, 2022

Choose a reason for hiding this comment

martenvd Jan 4, 2022

Choose a reason for hiding this comment

xuzhang3 commented Jan 4, 2022

xuzhang3 commented Jan 4, 2022

RodrigoGroener commented Jan 17, 2022 • edited Loading

martenvd commented Jan 3, 2022 •

edited

Loading

Does this introduce a change to `go.mod`, `go.sum` or `vendor/`?

RodrigoGroener commented Jan 17, 2022 •

edited

Loading