-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine minimum supported dependency versions #32
Comments
For testing, I think we can add a matrix field like: matrix:
dep-version: [oldest, latest] Then, during action setup, We could also use an |
pypa/pip#8085 would greatly help with this if it ever gets implemented. |
We depend on the latest release candidate of pytorch-lightning (1.4.0) to fix an issue with mypy (the problem where mypy doesn't think a LightningModule's hparams property is indexable) |
I would like to differentiate between dependency versions required for torchgeo to function and versions required for things like mypy to pass. We have hundreds of comments across torchgeo that ignore mypy warnings due to missing typing. These will likely change frequently. So the actual version required by torchgeo should be the minimum where the pytest tests pass. For things like mypy/Sphinx, we will always use the latest release. |
Now that we're using |
Just discovered that matplotlib does the same thing: https://github.com/matplotlib/matplotlib/blob/main/requirements/testing/minver.txt |
Before releasing, we should determine the minimum supported version of each dependency. We should also consider a test with this version just to make sure it doesn't change.
The text was updated successfully, but these errors were encountered: