[mpir] build failure (regression)

[josch]

Host Environment

• OS: Windows 10
• Compiler: VS 2017 & 2019

after this update:

mpir:x64-windows-v141            3.0.0-7 -> 3.0.0-8

I get the following error when building mpir:

Starting package 75/96: mpir:x64-windows-v141
Building package mpir[core]:x64-windows-v141...
-- Downloading https://github.com/wbhart/mpir/archive/mpir-3.0.0.tar.gz...
-- Extracting source C:/Tools/vcpkg/downloads/wbhart-mpir-mpir-3.0.0.tar.gz
-- Applying patch enable-runtimelibrary-toggle.patch
-- Using source at C:/Tools/vcpkg/buildtrees/mpir/src/mpir-3.0.0-c9f63a8302
-- Building C:/Tools/vcpkg/buildtrees/mpir/x64-windows-v141/build.vc15/dll_mpir_gc/dll_mpir_gc.vcxproj for Release
-- Installing: C:/Tools/vcpkg/packages/mpir_x64-windows-v141/include/gmp.h
-- Installing: C:/Tools/vcpkg/packages/mpir_x64-windows-v141/include/gmpxx.h
-- Installing: C:/Tools/vcpkg/packages/mpir_x64-windows-v141/include/mpir.h
-- Installing: C:/Tools/vcpkg/packages/mpir_x64-windows-v141/include/mpirxx.h
-- Installing: C:/Tools/vcpkg/packages/mpir_x64-windows-v141/bin/mpir.dll
-- Installing: C:/Tools/vcpkg/packages/mpir_x64-windows-v141/lib/mpir.lib
-- Installing: C:/Tools/vcpkg/packages/mpir_x64-windows-v141/share/mpir/copyright
-- Performing post-build validation
There should be no empty directories in C:\Tools\vcpkg\packages\mpir_x64-windows-v141
The following empty directories were found:
    C:/Tools/vcpkg/packages/mpir_x64-windows-v141/debug/bin
    C:/Tools/vcpkg/packages/mpir_x64-windows-v141/debug/lib
If a directory should be populated but is not, this might indicate an error in the portfile.
If the directories are not needed and their creation cannot be disabled, use something like this in the portfile to remove them:
    file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/a/dir" "${CURRENT_PACKAGES_DIR}/some/other/dir")
Found 1 error(s). Please correct the portfile:
    C:\Tools\vcpkg\ports\mpir\portfile.cmake
-- Performing post-build validation done
Error: Building package mpir:x64-windows-v141 failed with: POST_BUILD_CHECKS_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: mpir:x64-windows-v141
  Vcpkg version: 2020.02.04-nohash

full log:

https://ci.appveyor.com/project/josch/3dtk/builds/33540793/job/9y0wa55s08qv68a2?fullLog=true

[NancyLi1013]

Hi @josch
Thanks for posting this issue.
Have you changed something for mpir? I noticed that all ports were built with x64-windows-v141 in your full log.

Could you please provide the content included in x64-windows-v141 triplet?

[josch]

set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE dynamic)
set(VCPKG_BUILD_TYPE release)
set(VCPKG_PLATFORM_TOOLSET v141)

[NancyLi1013]

Hi @josch
Since you set VCPKG_BUILD_TYPE as release in the triplet, it will not build debug type again.

You can comment these two lines out.

file(INSTALL ${DBG_DLLS} DESTINATION ${CURRENT_PACKAGES_DIR}/debug/bin)
file(INSTALL ${DBG_LIBS} DESTINATION ${CURRENT_PACKAGES_DIR}/debug/lib)

Or add the condition to judge the build type.

if(NOT DEFINED VCPKG_BUILD_TYPE OR VCPKG_BUILD_TYPE STREQUAL "debug")

endif()

[josch]

Thanks for the patch -- I turned it into a pull request: #11964