Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[argtable3] spurious build failure #12297

Closed
BillyONeal opened this issue Jul 7, 2020 · 6 comments · Fixed by #18325
Closed

[argtable3] spurious build failure #12297

BillyONeal opened this issue Jul 7, 2020 · 6 comments · Fixed by #18325
Assignees
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly depends:upstream-changes Waiting on a change to the upstream project

Comments

@BillyONeal
Copy link
Member

BillyONeal commented Jul 7, 2020

Host Environment

  • OS: Windows Server 2019
  • Compiler: Visual Studio 2019 version 16.6

To Reproduce
Steps to reproduce the behavior:
./vcpkg install argtable3:x64-uwp (presumably)

Failure logs
argtable3.zip

Additional context
This failure appears to be spurious, there are likely races in the package's build system:

       "D:\buildtrees\argtable3\x64-uwp-dbg\install.vcxproj" (default target) (1) ->
       "D:\buildtrees\argtable3\x64-uwp-dbg\ALL_BUILD.vcxproj" (default target) (3) ->
       "D:\buildtrees\argtable3\x64-uwp-dbg\examples\ls.vcxproj" (default target) (7) ->
       (CustomBuild target) -> 
         CUSTOMBUILD : CMake error : Cannot restore timestamp D:/buildtrees/argtable3/x64-uwp-dbg/examples/CMakeFiles/generate.stamp [D:\buildtrees\argtable3\x64-uwp-dbg\examples\ls.vcxproj]
@BillyONeal
Copy link
Member Author

@BillyONeal
Copy link
Member Author

/cc @myd7349

@PhoebeHui
Copy link
Contributor

I didn't repro this issue locally, it might due to building the example in parallel, I updated this port to latest release revision 3.1.5, let 's see if it still occur in CI testing.

@PhoebeHui
Copy link
Contributor

The PR has been merged, and I haven't seen this failure on CI testing, close this issue now, would reopen this issue if it occur again.

@JackBoosY JackBoosY reopened this Jan 7, 2021
@JackBoosY JackBoosY self-assigned this Jan 7, 2021
@JackBoosY
Copy link
Contributor

It's a cmake bug: https://gitlab.kitware.com/cmake/cmake/-/issues/21571
Will be fixed by update cmake to the next version.

@JackBoosY JackBoosY added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly depends:upstream-changes Waiting on a change to the upstream project and removed requires:repro The issue is not currently repro-able labels Jan 7, 2021
@tomghuang
Copy link
Contributor

I've modified the CMake scripts in the latest v3.2.1 release, so we can use BUILD_SHARED_LIBS to control whether we're building a static or dynamic library. It's more aligned with the CMake recommendations and the vcpkg design, so we won't see any error in vcpkg, CMake, and the build process.

I'm preparing a pull request to update the port to Argtable3 v3.2.1, which should resolve most of the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants