Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg_fixup_pkgconfig] Remove the need to pass --static for static libraries #12937

Closed
Neumann-A opened this issue Aug 16, 2020 · 1 comment
Closed

[vcpkg_fixup_pkgconfig] Remove the need to pass --static for static libraries #12937

Neumann-A opened this issue Aug 16, 2020 · 1 comment
Assignees
@JackBoosY
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly

Comments

@Neumann-A
Copy link
Contributor

Simply make the pc file agnostic how the library was built and always do the correct thing.
Related comment #11836 (comment)
@ras0219 This separation probably has it roots in linux having both static and shared libraries available at the same time using the same pc file. vcpkg only builds one flavor so we don't care about those little details.
@NancyLi1013 NancyLi1013 added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Aug 17, 2020
@BillyONeal BillyONeal removed their assignment Aug 17, 2020
@JackBoosY JackBoosY self-assigned this Nov 3, 2020
@JackBoosY JackBoosY added category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly and removed category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed labels Nov 3, 2020
@Neumann-A
Copy link
Contributor Author

this was already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackBoosY JackBoosY

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BillyONeal @Neumann-A @NancyLi1013 @JackBoosY