Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portfile.cmake SHA512 values maybe should not care about lowercase/uppercase? #17756

Closed
TomasJohansson opened this issue May 9, 2021 · 3 comments · Fixed by microsoft/vcpkg-tool#269
Closed

portfile.cmake SHA512 values maybe should not care about lowercase/uppercase? #17756

TomasJohansson opened this issue May 9, 2021 · 3 comments · Fixed by microsoft/vcpkg-tool#269
Assignees
@JackBoosY @strega-nil-ms
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:manifests This PR or Issue pertains to the Manifests feature info:registries This PR or Issue pertains to the registries feature requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof

Comments

@TomasJohansson
Copy link

Is it necessary to consider SHA512 values as different just because of different uppercase/lowercase letters?
I got the error message below but I think the hashes should be considered as equal.

vcpkg install --feature-flags=registries,manifests

...
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:105 (message):
...
File does not have expected hash:
...
Expected hash: [ 381E8DA2CD0A841525CAD67625E18D8605E302168ADE0F88AF68415369DCD5CB6CCFD31738D92E138D8400E4F6B610E51AE9463B99752A89BCEC56ABCB15CD78 ]
Actual hash: [ 381e8da2cd0a841525cad67625e18d8605e302168ade0f88af68415369dcd5cb6ccfd31738d92e138d8400e4f6b610e51ae9463b99752a89bcec56abcb15cd78 ]
@JackBoosY
Copy link
Contributor

Should be lowercase.

@JackBoosY JackBoosY added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:registries This PR or Issue pertains to the registries feature labels May 10, 2021
@JackBoosY
Copy link
Contributor

cc @strega-nil

@JackBoosY JackBoosY added the info:manifests This PR or Issue pertains to the Manifests feature label May 14, 2021
@srgbtl srgbtl mentioned this issue Nov 12, 2021
Merged
@JackBoosY JackBoosY reopened this Nov 16, 2021
@JackBoosY JackBoosY added the requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof label Nov 16, 2021
@BillyONeal BillyONeal mentioned this issue Nov 16, 2021
Merged
@PhoebeHui
Copy link
Contributor

This issue should be fixed in latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackBoosY JackBoosY

@strega-nil-ms strega-nil-ms

Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) info:manifests This PR or Issue pertains to the Manifests feature info:registries This PR or Issue pertains to the registries feature requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hash: Make verification case-insensitive srgbtl/vcpkg-tool
4 participants
@TomasJohansson @PhoebeHui @JackBoosY @strega-nil-ms