Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow build failure #18282

Closed
ghamarian opened this issue Jun 5, 2021 · 7 comments
Closed

arrow build failure #18282

ghamarian opened this issue Jun 5, 2021 · 7 comments
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision

Comments

@ghamarian
Copy link

Host Environment

  • OS: osx
  • Compiler: clang 12

To Reproduce
Steps to reproduce the behavior:
./vcpkg install arrow

Failure logs
Port installs fine but when I make a project against it I get the following error.
make[2]: *** No rule to make target `/Users/amir/projects/github-code/vcpkg/installed/x64 osx/debug/lib/libarrow_bundled_dependencies.a'

find_package(arrow CONFIG REQUIRED)
target_link_libraries(database PRIVATE arrow_static parquet_static arrow_bundled_dependencies)
target_link_libraries(database PRIVATE LZ4::lz4 re2::re2 arrow_static Snappy::snappy)

Additional context
I tried both versions but gives the same error message. The older versions of the port generate arrow_bundled_dependencies.

@autoantwort
Copy link
Contributor

autoantwort commented Jun 5, 2021

There is no libarrow_bundled_dependencies.a, there is only a libarrow.a. I think you can simply remove arrow_bundled_dependencies from target_link_libraries

@ghamarian
Copy link
Author

Thanks for responding. I get the same error with or without it. I looked into ArrowConfig.cmake in <path to vcpkg>/packages/arrow_x64-osx/share/arrow
there is a code like this:

    add_library(arrow_bundled_dependencies STATIC IMPORTED)
    set_target_properties(
      arrow_bundled_dependencies
      PROPERTIES
        IMPORTED_LOCATION
        "${arrow_lib_dir}/${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}"
      )

    get_property(arrow_static_interface_link_libraries
                 TARGET arrow_static
                 PROPERTY INTERFACE_LINK_LIBRARIES)
    set_target_properties(
      arrow_static PROPERTIES INTERFACE_LINK_LIBRARIES
      "${arrow_static_interface_link_libraries};arrow_bundled_dependencies")

@autoantwort
Copy link
Contributor

It seems that here:
https://github.com/apache/arrow/blob/master/cpp/src/arrow/ArrowConfig.cmake.in#L75

ARROW_BUNDLED_STATIC_LIBS is True, but I can't find the code that sets it to true

@autoantwort
Copy link
Contributor

autoantwort commented Jun 5, 2021

Seems that it was already reported and fixed: apache/arrow#9622
I tried updating the lib, but got wired errors

@ghamarian
Copy link
Author

Oh! Thanks I missed it, so the vcpkg port does not work. I see there is a pull request for arrow version 4.0.0.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision labels Jun 7, 2021
@JackBoosY
Copy link
Contributor

We need to update arrow to fix this issue.

@JonLiu1993
Copy link
Member

@ghamarian ,pr #17975 Update arrow to 4.0.0. I tested arrow:x64-osx locally and it can be used successfully. You can update vcpkg and try again.This issue is temporarily closed. If you have any problems, you can reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

No branches or pull requests

4 participants