Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curl] build failure or rather configuration problem #19359

Closed
ulfllorenz opened this issue Aug 4, 2021 · 10 comments
Closed

[curl] build failure or rather configuration problem #19359

ulfllorenz opened this issue Aug 4, 2021 · 10 comments
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@ulfllorenz
Copy link
Contributor

Describe the bug
It is surprisingly difficult to build curl on Windows without the default non-http feature.

  • "vcpkg.exe install curl" installs curl[core,non-http,schannel,ssl,sspi,winssl], due to "non-http" being default. Fine so far.
  • "vcpkg.exe install curl[core,ssl]" also installs the non-http feature, which is a bit surprising, because I explicitly want to disable it.
  • "vcpkg.exe install curl[core,schannel]" installs curl[core,schannel,sspi], which is what I want.

I think the problem comes from the feature mapping ssl -> winssl -> schannel -> sspi, where only the latter two actually enter the CMake build. The feature winssl does not reference curl[core,schannel], but curl[schannel] (or, in the latest version, does not set default-features to false).

Since this behavior is different from Linux, I guess it counts as a bug.

@dg0yt
Copy link
Contributor

dg0yt commented Aug 4, 2021

Thanks for reporting! Feature winssl seems to miss "default-dependencies": false. I can pick this up for #18971.

@ulfllorenz
Copy link
Contributor Author

Another question: It may not fit here perfectly, but this is the fundamental reason I am playing around with curl: What is the status of issue #17919?

@dg0yt
Copy link
Contributor

dg0yt commented Aug 4, 2021

What is the status of issue #17919?

It is better to ask there, assuming that relevant people are subscribed there.

@dg0yt dg0yt mentioned this issue Aug 4, 2021
8 tasks
@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Aug 5, 2021

I think the problem comes from the feature mapping ssl -> winssl -> schannel -> sspi, where only the latter two actually enter the CMake build. The feature winssl does not reference curl[core,schannel], but curl[schannel] (or, in the latest version, does not set default-features to false).

Could you please provide what the detailed error you encountered for curl[core,ssl]? @ulfllorenz

@NancyLi1013
Copy link
Contributor

Another question: It may not fit here perfectly, but this is the fundamental reason I am playing around with curl: What is the status of issue #17919?

For #17919, it's duplicated to #14030, so you can focus on the status of #14030.

@NancyLi1013 NancyLi1013 added the requires:more-information This Issue requires more information to solve label Aug 5, 2021
@ulfllorenz
Copy link
Contributor Author

Thanks for the reply regarding the issue status. Regarding the detailed error, there is no error per se. I want to install curl

  • with ssl
  • http only (i.e., without "non-http")

Normally, you would install "curl[core,ssl]", but that expands to "curl[...,non-http,...]", which is not what I want. And the reason is that the intermediate feature winssl erroneously enables the default features (one of which is non-http).

@dg0yt
Copy link
Contributor

dg0yt commented Aug 5, 2021

@NancyLi1013 Look:

$ ./vcpkg depend-info curl[core,ssl]:x64-linux
openssl:
zlib:
curl[openssl, ssl]: openssl, zlib
$ ./vcpkg depend-info curl[core,ssl]:x64-windows
zlib:
curl[non-http, ssl, schannel, sspi, winssl]: zlib

@dg0yt
Copy link
Contributor

dg0yt commented Aug 5, 2021

For #17919, it's duplicated to #14030, so you can focus on the status of #14030.

@NancyLi1013 No, these issue are different: #14030 is missing LDAPS with WinLDAP. #17919 is uncontrolled system dependencies with OpenLDAP.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support and removed requires:more-information This Issue requires more information to solve labels Aug 9, 2021
@NancyLi1013
Copy link
Contributor

@ulfllorenz

Since #18971 has been merged, could you please try to update to the latest vcpkg to rebuild this?

@ulfllorenz
Copy link
Contributor Author

Looks good, produces good output, I think this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

No branches or pull requests

4 participants