Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Crash when attempting to upgrade not installed packages #25948

Closed
CookiePLMonster opened this issue Jul 23, 2022 · 1 comment
Closed

[vcpkg] Crash when attempting to upgrade not installed packages #25948

CookiePLMonster opened this issue Jul 23, 2022 · 1 comment
Assignees
@LilyWangLL
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@CookiePLMonster
Copy link
Contributor

CookiePLMonster commented Jul 23, 2022 •
edited
Loading

EDIT: The link Vcpkg provided for reporting this issue implied that I'd get this issue labeled with category:vcpkg-bug, however this didn't seem to have happened.

Describe the bug
Vcpkg reports a crash when attempting to upgrade a package that is either not installed or does not exist, as per the repro steps below.

Environment

  • OS: Windows 10 21H1
  • Compiler: Visual Studio 2022
  • Vcpkg version (output of ./vcpkg version): vcpkg package management program version 2022-07-21-a0e87e227afb536c62188c11ad029954f28fdb22

To Reproduce
Steps to reproduce the behavior. These steps assume that package foo does not exist.

  1. ./vcpkg upgrade foo:x86-windows
  2. Vcpkg reports failure, and crashes with an error: internal error: D:\a\_work\1\s\src\vcpkg\commands.upgrade.cpp(189): vcpkg has crashed; no additional details are available.

The same reproduction steps apply if the package in question is valid, but not installed.

Expected behavior
Vcpkg reports failure, as it does now, without crashing.

Failure logs
None pointed to by Vcpkg during the crash.
@CookiePLMonster CookiePLMonster changed the title Vcpkg crashes when attempting to upgrade not installed packages [vcpkg] Crash when attempting to upgrade not installed packages Jul 23, 2022
@LilyWangLL LilyWangLL self-assigned this Jul 25, 2022
@LilyWangLL LilyWangLL added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Jul 25, 2022
@LilyWangLL
Copy link
Contributor

Duplicated to #21117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LilyWangLL LilyWangLL

Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CookiePLMonster @LilyWangLL