Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tiff] zstd 1.5.2#1 tiff feature config file name update #28523

Closed
AbdulAbCellera opened this issue Dec 24, 2022 · 1 comment · Fixed by #28530
Closed

[tiff] zstd 1.5.2#1 tiff feature config file name update #28523

AbdulAbCellera opened this issue Dec 24, 2022 · 1 comment · Fixed by #28530
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@AbdulAbCellera
Copy link

AbdulAbCellera commented Dec 24, 2022

Since zstd 1.5.2#1, the zstd port has removed the renaming of CMake config files #22822. This change causes tiff[zstd] to fail if zstd is not added as an override with pinned to zstd 1.5.2#1. I see this issue only on Linux though.

The error is

CMake Error at vcpkg/scripts/buildsystems/vcpkg.cmake:843 (_find_package):
[cmake]   Could not find a package configuration file provided by "ZSTD" with any of
[cmake]   the following names:
[cmake] 
[cmake]     ZSTDConfig.cmake
[cmake]     zstd-config.cmake
[cmake] 
[cmake]   Add the installation prefix of "ZSTD" to CMAKE_PREFIX_PATH or set
[cmake]   "ZSTD_DIR" to a directory containing one of the above files.  If "ZSTD"
[cmake]   provides a separate development package or SDK, be sure it has been
[cmake]   installed.
[cmake] Call Stack (most recent call first):
[cmake]   vcpkg_installed/x64-linux-<>/share/tiff/vcpkg-cmake-wrapper.cmake:33 (find_package)
[cmake]   vcpkg/scripts/buildsystems/vcpkg.cmake:797 (include)
[cmake]   CMakeLists.txt:50 (find_package)
[cmake] 
[cmake] 
[cmake] -- Configuring incomplete, errors occurred!

The fix is very easy. find_package(ZSTD ...) should be replaced with a lowercase find_package(zstd ...).

find_package(ZSTD CONFIG ${z_vcpkg_tiff_find_options})

@dg0yt
Copy link
Contributor

dg0yt commented Dec 24, 2022

On my x64-linux, tiff configures and builds as expected:

--   ZSTD support:                       Requested:ON Availability:TRUE Support:TRUE

Building the current version of tiff simply falls back on its own FindZSTD.cmake.

The actual problem is not building but using TIFF. That's where the wrapper currently tries to use the wrong config.

@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants