Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiff build failure #38116

Closed
sgillies opened this issue Apr 10, 2024 · 8 comments
Closed

tiff build failure #38116

sgillies opened this issue Apr 10, 2024 · 8 comments
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@sgillies
Copy link

sgillies commented Apr 10, 2024

Operating system

Windows

Compiler

No response

Steps to reproduce the behavior

The tiff port builds with zstd and lerc features, but not with webp. Specifying this in my project's vcpkg.json results in a non-finishing build.

    "dependencies": [
        { "name": "tiff", "features": [ "zstd", "lerc", "webp" ] },
        "gdal"
    ],

Log excerpt is included below.

Failure logs

In config-x64-windows-out.log:

...
-- Found ZLIB: optimized;C:/vcpkg/installed/x64-windows/lib/zlib.lib;debug;C:/vcpkg/installed/x64-windows/debug/lib/zlibd.lib (found version "1.3.1")
-- Could NOT find Deflate (missing: Deflate_LIBRARY Deflate_INCLUDE_DIR)
-- Found JPEG: optimized;C:/vcpkg/installed/x64-windows/lib/jpeg.lib;debug;C:/vcpkg/installed/x64-windows/debug/lib/jpeg.lib (found version "62")
-- Could NOT find JBIG (missing: JBIG_LIBRARY JBIG_INCLUDE_DIR)
-- Found LERC: C:/vcpkg/installed/x64-windows/lib/Lerc.lib (found version "4.0.0")
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - not found
-- Found Threads: TRUE
CMake Error at C:/vcpkg/installed/x64-windows/share/WebP/WebPConfig.cmake:15 (message):
  File or directory C:/vcpkg/installed/include referenced by variable
  WebP_INCLUDE_DIR does not exist !
Call Stack (most recent call first):
  C:/vcpkg/installed/x64-windows/share/WebP/WebPConfig.cmake:38 (set_and_check)
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:859 (_find_package)
  cmake/WebPCodec.cmake:29 (find_package)
  CMakeLists.txt:123 (include)


-- Configuring incomplete, errors occurred!
ninja: build stopped: subcommand failed.

Additional context

@dg0yt I'd try to sort this out myself but I have no Windows computer.

@sgillies sgillies added the category:port-bug The issue is with a library, which is something the port should already support label Apr 10, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Apr 10, 2024

You are stumbling over CMake 3.29.1. Downgrade, and reinstall all ports which were built with that version.
#37968

@sgillies
Copy link
Author

sgillies commented Apr 10, 2024

All of tiff and not just the webp feature, then. Ugh. Thanks for the explanation @dg0yt ! I really do appreciate your work on the GDAL-related packages her 🙏

@sgillies
Copy link
Author

@dg0yt I'm finding it difficult to downgrade or tell vcpkg to use my downgraded version. The GitHub runners have 3.29.1 and installing cmake 3.28.4 via pip or the lukka/get-cmake action (which I've seen others do) doesn't work. In the tiff build logs I still only see references to 3.29.

cd tiff; grep -R "3.29" .
./config-x64-windows-rel-CMakeCache.txt.log:CMAKE_ROOT:INTERNAL=C:/Program Files/CMake/share/cmake-3.29
./config-x64-windows-dbg-CMakeCache.txt.log:CMAKE_ROOT:INTERNAL=C:/Program Files/CMake/share/cmake-3.29

@jimwang118
Copy link
Contributor

You can try PR 38017 to see if it can solve your problem.

@jimwang118
Copy link
Contributor

@sgillies Does it compile normally after you downgrade cmake to 3.29.0 or upgrade to 3.29.2?

@sgillies
Copy link
Author

@jimwang118 I'm using GitHub Actions, where the runners didn't have 3.29.2 until yesterday, and found it too difficult to convince vcpkg to not use the pre-installed cmake. So I went with an overlay port for vcpkg-cmake-config.

@jimwang118
Copy link
Contributor

@sgillies Is your issue solved now?

@sgillies
Copy link
Author

sgillies commented Jun 5, 2024

@jimwang118 I don't know for certain. I haven't had the free time to see if my overlay port can be removed. GHA windows-latest runners have cmake 3.29.3 now, so I'll presume the problem is fixed and close this issue. Thanks for the support!

@sgillies sgillies closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

No branches or pull requests

3 participants