Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[theia] update to 0.8 #42099

Closed
StonerLing opened this issue Nov 11, 2024 · 5 comments
Closed

[theia] update to 0.8 #42099

StonerLing opened this issue Nov 11, 2024 · 5 comments
Assignees
Labels
category:question This issue is a question

Comments

@StonerLing
Copy link

StonerLing commented Nov 11, 2024

Library name

theia

New version number

0.8

Other information that may be useful (release notes, etc...)

It appears that when the theia library is installed automatically, the command line interface shows version 0.8, but the installation result is version 0.7 (as indicated in the CMake config file).

@StonerLing StonerLing added the category:port-update The issue is with a library, which is requesting update new revision label Nov 11, 2024
@StonerLing StonerLing changed the title [theia] update to 0.08 [theia] update to 0.8 Nov 11, 2024
@StonerLing
Copy link
Author

After investigation, I found that the issue was due to an incorrect version setting in the CMakeLists of Theia's source code. When the library release version was 0.8, the CMakeLists version remained at 0.7. Can vcpkg modify the corresponding CMake configuration file to obtain the correct version information?

@dg0yt
Copy link
Contributor

dg0yt commented Nov 11, 2024

Upstream seems to be inactive since 5 years, Should this really be fixed now?

@StonerLing
Copy link
Author

I believe this bug is due to an error by the author of Theia, and the code repository has not been updated further. The latest master branch has undergone significant changes without a new version being released. However, for developers using vcpkg to manage and utilize the Theia library, the mismatch in version information may lead to some misunderstandings. In summary, this is a fix that is desirable but not mandatory.

@dg0yt
Copy link
Contributor

dg0yt commented Nov 11, 2024

I believe this bug is due to an error by the author of Theia, and the code repository has not been updated further.

I agree.

The latest master branch has undergone significant changes without a new version being released.

And still, changes stopped 5 years ago.

However, for developers using vcpkg to manage and utilize the Theia library, the mismatch in version information may lead to some misunderstandings. In summary, this is a fix that is desirable but not mandatory.

If a fix is applied in vcpkg but not by other packaging providers, this might be even more confusing and causing lock-in. As a vcpkg user, you can rely on versioning in manifest mode.

@StonerLing
Copy link
Author

If a fix is applied in vcpkg but not by other packaging providers, this might be even more confusing and causing lock-in

I got it.

The long period without updates has also resulted in many minor bugs. I've decided to compile from the source code myself~

@Cheney-W Cheney-W added category:question This issue is a question and removed category:port-update The issue is with a library, which is requesting update new revision labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:question This issue is a question
Projects
None yet
Development

No branches or pull requests

3 participants