Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new built-in telemetry masking #1104

Closed
bwateratmsft opened this issue Apr 5, 2022 · 1 comment · Fixed by #1622
Closed

Use new built-in telemetry masking #1104

bwateratmsft opened this issue Apr 5, 2022 · 1 comment · Fixed by #1622
Labels
engineering

Comments

@bwateratmsft
Copy link
Contributor

The @vscode/extension-telemetry package recently added support for custom masking. (Note: At the time of writing it has not yet been released.)

We should investigate using this instead of our current more ad-hoc masking logic. One limitation is that it doesn't support adding masks after-the-fact, so we would need to see if it's possible to change all of our masks to more generic, statically-defined regexs.
@bwateratmsft bwateratmsft self-assigned this Apr 5, 2022
@bwateratmsft bwateratmsft mentioned this issue Jun 15, 2022
Closed
2 tasks
@bwateratmsft
Copy link
Contributor Author

Related to #1360 as well

@bwateratmsft bwateratmsft mentioned this issue Apr 19, 2023
Closed
@bwateratmsft bwateratmsft removed their assignment Apr 19, 2023
@bwateratmsft bwateratmsft linked a pull request Nov 8, 2023 that will close this issue
utils: Update @vscode/extension-telemetry and do npm audit fix #1622
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engineering
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

utils: Update @vscode/extension-telemetry and do npm audit fix microsoft/vscode-azuretools
1 participant
@bwateratmsft