Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable substitution does not work #1056

Closed
jorisvanderpol opened this issue Feb 10, 2020 · 5 comments
Closed

Variable substitution does not work #1056

jorisvanderpol opened this issue Feb 10, 2020 · 5 comments
Assignees
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: language services
Milestone

Comments

@jorisvanderpol
Copy link

Variable substitution in cmake-kits.json does not work properly:

{
    "name": "gcc-arm-none-eabi",
    "toolchainFile": "${workspaceFolder:BuildSystem}/toolchains/gcc-arm-none-eabi.cmake"
}

If I use ${workspaceFolder}/../BuildSystem for example, it works.

Same problem in the settings.json file:

"cmake.configureSettings": {
    "BUILDSYSTEM_DIRECTORY": "${workspaceFolder:BuildSystem}"
}

Visual Studio Code: 1.42
CMake Tools: 1.3.0

@bobbrow
Copy link
Member

bobbrow commented Feb 10, 2020

This might be addressed by PR #991. @andreeis can you check?

@bobbrow
Copy link
Member

bobbrow commented Feb 10, 2020

To clarify, this is not currently supported, but we do plan to support it in the future.

@bobbrow bobbrow added enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: language services labels Feb 10, 2020
@andreeis andreeis added this to the 1.4.0 milestone Feb 11, 2020
@bobbrow bobbrow modified the milestones: 1.4.0, 1.5.0 May 7, 2020
@btgoodwin
Copy link

btgoodwin commented Oct 29, 2020

It sounds like this is resolved, based on that fixed (release pending) label. Is there an estimate for when this might be released?

@bobbrow bobbrow modified the milestones: 1.6.0, 1.5.0 Nov 5, 2020
@andreeis
Copy link
Contributor

andreeis commented Nov 5, 2020

This should be fixed in CMake Tools 1.5.0 which was published today.
Let us know if you encounter any issues with this release.

@andreeis andreeis closed this as completed Nov 5, 2020
@btgoodwin
Copy link

Excellent, thank you. This seems to have fixed it for me.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: language services
Projects
None yet
Development

No branches or pull requests

4 participants