Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal is focused after running "CMake: Run Without Debugging" #1138

Closed
STaRDoGGCHaMP opened this issue Mar 23, 2020 · 2 comments · Fixed by #1452
Closed

Terminal is focused after running "CMake: Run Without Debugging" #1138

STaRDoGGCHaMP opened this issue Mar 23, 2020 · 2 comments · Fixed by #1452
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature help wanted we currently are not planning work on this and would like help from the open source community more votes needed We currently are de-prioritizing this issue until more community up-votes are provided
Milestone
Backlog

Comments

@STaRDoGGCHaMP
Copy link

Brief Issue Summary

When running the CMake: Run Without Debugging command, the terminal gets focused after the program has finished its execution.

Expected:

The extension should not put focus on the terminal or an option should be provided to control this behavior.

Apparent Behavior:

Focus is put on the terminal and no option is given to control this behavior.

Platform and Versions

  • Operating System: Windows 10
  • CMake Version: 3.16.19112601-MSVC_2
  • VSCode Version: 1.43.1 fe22a9645b44368865c0ba92e2fb881ff1afce94 x64
  • CMake Tools Extension Version: 0.0.17
  • Compiler/Toolchain: Visual Studio 2019 version 16.5
@bobbrow
Copy link
Member

bobbrow commented Mar 28, 2020

I believe the code is supposed to just show the active terminal window. Is it taking focus away from another window? It seems easy enough to fix, but not a high priority relative to the other bugs we're looking at right now. If someone wants to submit a PR, we'll review it.

@bobbrow bobbrow added enhancement an enhancement to the product that is either not present or an improvement to an existing feature more votes needed We currently are de-prioritizing this issue until more community up-votes are provided labels Mar 28, 2020
@bobbrow bobbrow added this to the Backlog milestone Mar 28, 2020
@bobbrow bobbrow added the help wanted we currently are not planning work on this and would like help from the open source community label Mar 28, 2020
@STaRDoGGCHaMP
Copy link
Author

STaRDoGGCHaMP commented Apr 4, 2020 •
edited
Loading

Is it taking focus away from another window?

Yes. Most importantly, it takes away focus from the editor.

@estshorter estshorter mentioned this issue Sep 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature help wanted we currently are not planning work on this and would like help from the open source community more votes needed We currently are de-prioritizing this issue until more community up-votes are provided
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Preserve focus when executing "CMake: Run Without Debugging"
3 participants
@STaRDoGGCHaMP @bobbrow @andreeis