-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EBUSY error from "C:\DumpStack.log.tmp" #1430
Comments
I figure it out by myself according to : https://answers.microsoft.com/en-us/windows/forum/all/dumpstacklog-file/eba04d25-bac2-4173-b9d5-b1a8fc47f64e But, it still will make VSCode extension host crash with new messages:
|
I am experiencing this issue as well, same platform and versions (cmake-tools v1.4.2). Crashes are so frequent that it is unusable on larger project builds. |
The second issue about "message must be set" has been fixed in the 1.4.2 version. For the beginning issue, I think it may not because of cmake tools itself, it should be the npm packages stuff related, because now I get another issue for the 'resource busy or locked' from 'c:\hiberfil.sys'. I haven't find the root cause, I just disabled all of extensions, and to check which extension has some conflicts with cmake tools. |
@bobbrow, thanks for your attention. Yes, I deleted my message few days ago, because that was not the right solution for this issue. Today, I try to delete whole BTW, can you explain something about the root cause of this issue? Why chokidar try to touch those files? c:\DumpStack.log.tmp, c:\hiberfil.sys, ... I wanted to figure out its root cause by myself, but it could be nice if you can give me some tips. |
I found the root cause of this issue finally. @bobbrow, I think your PR is not relevant for this issue although the 'node_modules' is meaningless in production. let me summary my finding: VS Code Version: 1.49.2
Note: If only enable few of extensions, such as:
It will not cause extension host crash, although it still throw above error log watched in Developer Tools, the VS Code Extension Host stay in running. After enabling more and more extensions, it will make the extension host crash, but not sure about which extension affects this. Root cause:
So, after Then, if any file changed, like: 'c:\hiberfil.sys' or 'c:\DumpStack.log.tmp', chokidar will trigger the error because chokidar has not permission to use them. Check the issue from chokidar github repo: paulmillr/chokidar#1037 Solution: Actually, in the Troubleshooting way:
Workaround before new version New Result from workaround: @bobbrow This fix is very simple, I think you can do that by yourself, Or, If let me to create a PR, which branch can be used to create a feature branch? and does the 'develop' branch is target for PR? |
Thank you for your very detailed analysis! If you have time to create a pull request to fix this, we will be happy to review and accept it. Use the 'develop' branch as the target for the PR. |
We now publish builds of the extension with each commit to the repository. If you would like to help validate the fix for this, you can download the latest cmake-tools.vsix here: https://github.com/microsoft/vscode-cmake-tools/actions/runs/331832244 Unzip the download and then invoke the "Install from VSIX" command in VS Code to install it. |
Thanks. I think for now I'll keep CMake disabled, because another issue I've been experiencing is that it starts "Initializing" task and notification even on projects without CMakeLists.txt in the root dir. This has been quite annoying too, but not sure if it count as an issue. |
The extension will initialize if a CMakeLists.txt exists somewhere in the folder, but it shouldn't do much unless you've set the |
Fair enough :) I think I most commonly observed this on either Rust or even Node.js projects where one of the dependencies (or dependency of a dependency 😅) in some nested dir might have been a CMake project, but one that I obviously don't care about, since it's not the root project I'm working on. Yet, CMake was popping up with "do you want to initialize this project?" dialogue every time. Hopefully this helps, but I'll try to re-enable the extension and see if I have a more concrete example. |
Since last time I did the quick fix like this:
I already used CMake Tools in my production project since last time, and it is quite stable and not found any crash yet. BTW, my job depends on VS Code totally, but the extensions are not so stable, so I use some strategies, like disable the extensions auto update function. For cmake tools, I usually set
in the vscode user settings to let CMake tools not disturbing me. |
Brief Issue Summary
cmakes-tools make vscode extension host crash
Expected:
No crash to restart the extension host
Apparent Behavior:
CMake Tools Log
N/A.
Developer Tools Log
Platform and Versions
Other Notes/Information
The text was updated successfully, but these errors were encountered: