-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Studio kits are not detected when temp folder has a space in it #1492
Comments
Can you give us more information about your current installation state?
|
Note: After examining the log a bit, it seems that it did pick up the installation because of |
Thank you for the extra info. We will try to reproduce this and debug. I wasn't able to spot anything suspicious yet from a quick glance at the extension source code, following up on the hints from your logs. |
Only if it's not too difficult, can you try to install 1.4.1 instead of 1.4.2 and rescan the kits? |
I tried version 1.4.1, and it still didn't find the kit. On a side note, I recalled my history a bit further because I uninstalled and installed Visual Studio a lot in the past. It worked when I had Visual Studio Build Tools and was able to pick it up. As soon as I uninstall that though, I also removed all the entries in the kits JSON file because I don't think CMake Tools removes non-existent kits back then. Then that was when it no longer picked up any further installations of Visual Studio (and that was when the supposedly |
The problem appears to be related to having a space in the path. @andreeis can you try putting the temp bat file in a path with a space in it and see if that reproduces the error?
|
Yes that's it. I also thought to experiment with quoting to fix this but for some reason things still don't work well if I make sure to quote some paths in our code base. I'm sure that after a bit more time I can find a good fix. In the meantime I can create a low priority work item to make the extension deal with the space path as well. |
I think this is worthy to include in 1.5. |
So the actual issue is the fact my home path has a space? If so, should I rename this issue to better reflect that? |
Removing the space is just your workaround until we release 1.5. The extension should still handle this scenario. We are working on a fix right now. Thank you for reporting this. |
Unfortunately, I can't really rename my user folder since that'd break many other things. I have patience 😄 ! |
This should be fixed in CMake Tools 1.5.0 which was published today. |
Yep it works! Thank you! |
Brief Issue Summary
CMake Tools is unable to detect Visual Studio kits. It doesn't matter if it's Release or Preview version, because I tried them all. I can use "unspecified" to make it use the Visual Studio kit, but that doesn't really solve the main problem.
Expected:
CMake Tools should detect Visual Studio kits
Apparent Behavior:
It finds every other compiler EXCEPT Visual Studio (it even finds Clang with MSVC)
CMake Tools Log
Developer Tools Log
Platform and Versions
Other Notes/Information
It was working fine for some time, but I noticed it stopped working after one of the times I uninstalled Visual Studio to install the Preview version.
The text was updated successfully, but these errors were encountered: