Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable substitution stopped working in 1.5 and VS Code 1.51 #1526

Closed
hriekehof opened this issue Nov 6, 2020 · 5 comments
Closed
Labels
bug a bug in the product Feature: configure regression used to work and no longer does. Regressions are typically high priority
Milestone

Comments

@hriekehof
Copy link

Brief Issue Summary

So far i defined a custom build directory via "cmake.buildDirectory": ${env:MY_BUILD_FOLDER}/${buildKit}/${buildType}
Today i updated VS Code and the extension and suddenly i get an error from rollbar:

[rollbar] Ausnahmefehler: Fehler beim Schreiben in Datei "${env:MY_BUILD_DIR}\xxx\RelWithDebInfo\.cmake\api\v1\query\client-vscode\query.json". Error: ENOENT: no such file or directory

It seems that the variable substitution for environment variables is not working anymore. When i use just ${workspaceFolder} for example everything works.

Platform and Versions

  • Operating System: Windows
  • CMake Version: 3.18
  • VSCode Version: 1.51
  • CMake Tools Extension Version: 1.5
  • Compiler/Toolchain: arm-none-eabi-gcc
@bobbrow
Copy link
Member

bobbrow commented Nov 6, 2020

Thank you for reporting this. We will investigate and get a patch out soon.

@bobbrow bobbrow added bug a bug in the product Feature: configure IMPORTANT regression used to work and no longer does. Regressions are typically high priority labels Nov 6, 2020
@bobbrow bobbrow added this to the 1.5.1 milestone Nov 6, 2020
@BarrettLowe
Copy link

Maybe related: after updating I cannot resolve cmake variables in the cmake.buildDirectory setting.

${variant:buildType} seems to resolve to nothing...

Does this sound like tit's related? I will open a new issue if not.

@bobbrow
Copy link
Member

bobbrow commented Nov 6, 2020

The variant substitution issue is covered by #1525. I suspect they could be related, but in any case we are looking at both of them.

In the meantime, if you are blocked you can revert back to 1.4.2 by clicking the gear icon next to CMake Tools in the extensions panel and selecting "Install Another Version...":
image

@andreeis
Copy link
Contributor

andreeis commented Nov 6, 2020

This bug fix is included in CMake Tools 1.5.1 which was just released today.
Let us know if you encounter any other problems.

@andreeis andreeis closed this as completed Nov 6, 2020
@hriekehof
Copy link
Author

works perfectly again. thanks for the quick fix 👍

@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug a bug in the product Feature: configure regression used to work and no longer does. Regressions are typically high priority
Projects
None yet
Development

No branches or pull requests

4 participants