Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$vendor is not expanded correctly #1966

Closed
xisui-MSFT opened this issue Jun 30, 2021 · 2 comments
Closed

$vendor is not expanded correctly #1966

xisui-MSFT opened this issue Jun 30, 2021 · 2 comments

Comments

@xisui-MSFT
Copy link
Collaborator

Just found that I forgot to change this after copying other entries:

const vendor_re = RegExp(`\\$vendor\\{(${varValueRegexp})\\}`, "g");
while ((mat = vendor_re.exec(tmpl))) {
const full = mat[0];
const varname = mat[1];
const repl = fixPaths(process.env[normalizeEnvironmentVarname(varname)] || '') || '';
subs.set(full, repl);
}

@esweet431 Do we support any vendor macros now?

@esweet431
Copy link
Contributor

Just one (https://docs.microsoft.com/en-us/cpp/build/cmake-presets-json-reference?view=msvc-160#microsoft-vendor-macros) but it's not supported by VS Code.

@andreeis
Copy link
Contributor

Fixed in 1.8.

@bobbrow bobbrow added this to the 1.8.0 milestone Oct 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants