Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn the user about CMAKE_BUILD_TYPE inconsistencies #2096

Closed
bobbrow opened this issue Aug 31, 2021 · 1 comment
Closed

Warn the user about CMAKE_BUILD_TYPE inconsistencies #2096

bobbrow opened this issue Aug 31, 2021 · 1 comment
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: debug/launch help wanted we currently are not planning work on this and would like help from the open source community
Milestone
1.9.1

Comments

@bobbrow
Copy link
Member

bobbrow commented Aug 31, 2021

I just spent some time troubleshooting #2074. The root cause was a CMakeLists.txt changing the CMAKE_BUILD_TYPE to something other than what was passed on the generator command line. As a result no target for launch/debug could be selected because there were no targets listed for that build type in the file-api folder. (e.g. buildType was set to "Debug", but targets were all generated as "Release")
@bobbrow bobbrow added enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: debug/launch labels Aug 31, 2021
@tilman22
Copy link

tilman22 commented Sep 2, 2021

[Good idea - I spend a couple of hours why Intellisense was not working correctly any more. We change the CMAKE_BUILD_TYPE macro in order to be sure which compiler-switches we are using]

@andreeis andreeis added this to the Backlog milestone Oct 4, 2021
@andreeis andreeis added the help wanted we currently are not planning work on this and would like help from the open source community label Oct 4, 2021
@andreeis andreeis mentioned this issue Oct 4, 2021
Closed
This was referenced Oct 15, 2021
Closed
Merged
@bobbrow bobbrow modified the milestones: Backlog, On Deck Oct 22, 2021
@bobbrow bobbrow modified the milestones: On Deck, 1.9.1 Oct 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: debug/launch help wanted we currently are not planning work on this and would like help from the open source community
Projects
None yet
Milestone
1.9.1
Development

No branches or pull requests
3 participants
@tilman22 @bobbrow @andreeis