issue with presets (v3) and "toolchainFile"

[anb0s]

Brief Issue Summary

We are using the version 1.9.0 for CMake presets v3 support and instead of:

      "cacheVariables": {
        "CMAKE_TOOLCHAIN_FILE": "cmake/toolchains/linux_gcc_x86_64_x32.cmake"
      }

with the output:

[proc] Executing command: /usr/bin/cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_TOOLCHAIN_FILE=cmake/toolchains/linux_gcc_x86_64_x32.cmake -H/home/andre/git/project -B/home/andre/git/project/build/default -G Ninja
[cmake] -- The C compiler identification is GNU 10.2.1
[cmake] -- The CXX compiler identification is GNU 10.2.1

now we want to use toolchainFile:

     "toolchainFile": "cmake/toolchains/linux_gcc_x86_64.cmake"

and here we are facing the issue:

[proc] Executing command: /usr/bin/cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_TOOLCHAIN_FILE="cmake/toolchains/linux_gcc_x86_64_x32.cmake" -H/home/andre/git/project -B/home/andre/git/project/build/default -G Ninja
[cmake] CMake Error at /usr/share/cmake-3.21/Modules/CMakeDetermineSystem.cmake:130 (message):
[cmake]   Could not find toolchain file:
[cmake]   "cmake/toolchains/linux_gcc_x86_64_x32.cmake"
[cmake] Call Stack (most recent call first):
[cmake]   CMakeLists.txt:3 (project)

It looks like the parameter is now passed still as -DCMAKE_TOOLCHAIN_FILE= but with quotes and something is different at command line, here the both variants are working...

[bobbrow]

Can you try:

"toolchainFile": "${sourceDir}/cmake/toolchains/linux_gcc_x86_64.cmake"

[anb0s]

Yes, sure, i've already tried, but same result:

[proc] Executing command: /usr/bin/cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_TOOLCHAIN_FILE="/home/andre/git/project/cmake/toolchains/linux_gcc_x86_64_x32.cmake" -H/home/andre/git/project -B/home/andre/git/project/build/default -G Ninja
[cmake] CMake Error at /usr/share/cmake-3.21/Modules/CMakeDetermineSystem.cmake:130 (message):
[cmake]   Could not find toolchain file:
[cmake]   "/home/andre/git/project/cmake/toolchains/linux_gcc_x86_64_x32.cmake"
[cmake] Call Stack (most recent call first):
[cmake]   CMakeLists.txt:3 (project)

[anb0s]

I'm curious why it works in bash:

/usr/bin/cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_TOOLCHAIN_FILE="cmake/toolchains/linux_gcc_x86_64_x32.cmake" -H/home/andre/git/project -B/home/andre/git/project/build/default -G Ninja
-- The C compiler identification is GNU 10.2.1
-- The CXX compiler identification is GNU 10.2.1

P.S.. i have created an issue at CMake first, but if it's working in bash, what is the defference?

[bobbrow]

I took a look at the code and it looks like that cmake command is not run in a shell context, so the quotes added after the = are incorrect. I opened a PR to fix it. I'll share an internal build afterward if you would like one, or you can continue setting CMAKE_TOOLCHAIN_FILE in the cacheVariables section until we release 1.9.1 which will contain some other patches.

[anb0s]

Thanks, i'm fine with waiting and test 1.9.1 then.

[andreeis]

@anb0s, a fix for this problem was included in the CMake Tools 1.9.1 release. Upgrade your extension in VSCode and let us know if you encounter any other issues.