Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ninja not able to build single-threaded starting with 1.9.1 #2222

Closed
andreeis opened this issue Nov 2, 2021 · 3 comments · Fixed by #2320
Closed

Ninja not able to build single-threaded starting with 1.9.1 #2222

andreeis opened this issue Nov 2, 2021 · 3 comments · Fixed by #2320
Assignees
@elahehrashedi
Labels
bug a bug in the product Feature: build
Milestone
On Deck

Comments

@andreeis
Copy link
Contributor

andreeis commented Nov 2, 2021

The fix for #1958 was meant for msbuild only, not as a general rule to skip over "-j" when parallelJobs is set to 1. This breaks ninja which cannot build single-threaded with CMT extension anymore.
@andreeis andreeis added bug a bug in the product Feature: build IMPORTANT labels Nov 2, 2021
@andreeis andreeis added this to the On Deck milestone Nov 2, 2021
@mark-ulrich
Copy link
Contributor

This was my fear when submitting the PR. So what is the best solution? Is it to add a new configuration option? I considered this when creating the fix, but I was/am not familiar enough with the codebase to do so. I would be happy to work on this if no one else is working on it at the moment.

@bobbrow
Copy link
Member

bobbrow commented Nov 22, 2021

@mark-ulrich If you are willing to help out with this, we would appreciate it.

@elahehrashedi elahehrashedi mentioned this issue Jan 11, 2022
Merged
@bobbrow
Copy link
Member

bobbrow commented Mar 1, 2022

The fix for this issue is available in 1.10 "pre-release". You can help us validate it by:

  1. Opening the extensions panel in VS Code
  2. Selecting the CMake Tools extension
  3. Clicking the "Switch to Pre-release Version" button

image

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@elahehrashedi elahehrashedi

Labels
bug a bug in the product Feature: build
Projects
None yet
Milestone
On Deck
Development

Successfully merging a pull request may close this issue.

Configure number of jobs (-j build args) for Ninja microsoft/vscode-cmake-tools
4 participants
@mark-ulrich @bobbrow @elahehrashedi @andreeis