Stop using -H to configure projects
#2292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -H flag is an undocumented feature that was never supposed to be used by the public. This commit makes the drivers use the appropriate methods of configuring depending on the CMake version they handle: Legacy: The binary directory has to be created first and CMake must be invoked with that folder as its working directory. The source directory is passed without any flags. ServerAPI: The binary directory was already ensured to exist. No changes necessary. FileAPI: The driver for this assumes CMake >= 3.15, so the -S and -B flags can be used. These flags were introduced in CMake 3.13. Fixes: microsoft#2053
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -H flag is an undocumented feature that was never supposed to be
used by the public. This commit makes the drivers use the appropriate
methods of configuring depending on the CMake version they handle:
Legacy: The binary directory has to be created first and CMake must be
invoked with that folder as its working directory. The source directory
is passed without any flags.
ServerAPI: The binary directory was already ensured to exist. No changes
necessary.
FileAPI: The driver for this assumes CMake >= 3.15, so the -S and -B
flags can be used. These flags were introduced in CMake 3.13.
Fixes: #2053
This changes visible behavior