Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to rescan for kits in the Kits QuickPick #864

Closed
Zingam opened this issue Nov 1, 2019 · 6 comments
Closed

Add the ability to rescan for kits in the Kits QuickPick #864

Zingam opened this issue Nov 1, 2019 · 6 comments
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: kits
Milestone

Comments

@Zingam
Copy link
Contributor

Zingam commented Nov 1, 2019

I tried the current extension on a machine that also has BlackBerry QNX Momentics installed which contains a GCC toolchain. VSCode finds the the QNX GCC toolchain as a kit but fails to find MSVC (I have Visual Studio 2019 Preview installed).
On another machine which contains only Visual Studio 2019, VS2019 Preview and Clang LLVM 9.0. For some reason the only toolkit that the CMake Tools find is called Visual Studio Enterprise:
Untitled
There is no Visual Studio 2019 Community Version and no Visual Studio 2019 Community Preview version.
Maybe I used to have a preview version of VS Enterprise once installed (long time ago before the release of VS2019).
The extension also doesn't find Clang. It is not in the path but maybe it should look for a variable LLVM_ROOT or something.

@bobbrow
Copy link
Member

bobbrow commented Nov 1, 2019

1.2.0 should have a fix for this. We didn't get it ready in time to release this week. We're targeting Monday now.

@bobbrow bobbrow added this to the 1.2.0 milestone Nov 1, 2019
@bobbrow
Copy link
Member

bobbrow commented Nov 5, 2019

CMake Tools 1.2.0 is now available in the VS Code Marketplace or on the Releases Page.

Because the publisher id has changed, VS Code does not automatically upgrade you yet. The Marketplace team will enable this in the next few days. If you want to install 1.2.0 now, please make sure you uninstall any earlier versions of CMake Tools manually to avoid any conflicts.

@bobbrow bobbrow closed this as completed Nov 5, 2019
@Zingam
Copy link
Contributor Author

Zingam commented Nov 7, 2019

This is not fixed. I still see VS Enterprise Preview instead of any of the VS 2019 Community versions that I have installed. Neither does the extension find my LLVM installation.

@bobbrow
Copy link
Member

bobbrow commented Nov 7, 2019

Did you rerun the "Scan for Kits" command?

@Zingam
Copy link
Contributor Author

Zingam commented Nov 7, 2019

You are right! I have completely forgotten about that command:

User-Local Kits can be updated by running Scan for Kits in the command palette. The following process occurs to find available kits:

I'd click on the status bar to select a kit and I'd think that's all I needed to do. Perhaps the select menu kit drop-down list could feature a Re-Scan option to remind to noobs like me that there is such an option.

@bobbrow
Copy link
Member

bobbrow commented Nov 7, 2019

That's a good idea. I'll change the issue title and turn this into a feature request.

@bobbrow bobbrow reopened this Nov 7, 2019
@bobbrow bobbrow added enhancement an enhancement to the product that is either not present or an improvement to an existing feature and removed bug a bug in the product fixed (release pending) labels Nov 7, 2019
@bobbrow bobbrow changed the title Unable to find MSVC on Windows 10 (improper detection of kits) Add the ability to rescan for kits in the Kits QuickPick Nov 7, 2019
@bobbrow bobbrow modified the milestones: 1.2.0, 1.3.0 Nov 13, 2019
@andreeis andreeis closed this as completed Feb 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement an enhancement to the product that is either not present or an improvement to an existing feature Feature: kits
Projects
None yet
Development

No branches or pull requests

3 participants