Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Toolbar icons are not centered #139

Closed
pouyakary opened this issue Oct 10, 2022 · 5 comments
Closed

Some Toolbar icons are not centered #139

pouyakary opened this issue Oct 10, 2022 · 5 comments
Assignees

Comments

@pouyakary
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.72.0
  • OS Version: 12.5.1

These two icons are not centered in the toolbar. This occurs everywhere:

Screen Shot 2022-10-10 at 4 52 50 PM

Screen Shot 2022-10-10 at 4 53 18 PM

@pzakeri22
Copy link

I am happy to work on this issue if needed

@mjbvz mjbvz assigned daviddossett and unassigned mjbvz Oct 28, 2022
@daviddossett
Copy link
Contributor

Transferring to the Codicons repo.

@daviddossett daviddossett transferred this issue from microsoft/vscode Oct 28, 2022
@daviddossett
Copy link
Contributor

Here's the basic problem. Codicons are built on an even pixel grid, which makes things challenging when you introduce elements that are supposed to sit directly in the middle.

Current icon, offset by design to account for this:

CleanShot 2023-05-01 at 15 35 06@2x

Here's how this looks if the container is perfectly even—you can't center the divider

CleanShot 2023-05-01 at 15 35 14@2x

I may consider changing this icon anyway, but wanted to share the immediate challenge that I saw.

@pouyakary
Copy link
Author

pouyakary commented May 1, 2023

Every time I mistake the problem for wrong padding and then arrive at this problem :) damn evens :))

@hbons
Copy link
Member

hbons commented Mar 21, 2024

Tracking in #243

@hbons hbons closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants