-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intellisense #include completion does not display package-like foo.bar header files #5698
Comments
Would showing types associated with "c" or "cpp" in the files.associations be sufficient? Or did you want a setting to show all types? Or did you have some other idea? |
Showing only types associated with c and cpp wouldn’t be enough as there is no efficient way to associate these files except by using a pattern |
It's feasible (might have some performance impact). |
When do you think this could be integrated ? What is the policy about 'enhancement' integrations ? |
I don't know. It's not a matter of being "integrated" it's a matter of being "changed"/"fixed". The change would have to be done in our closed source cpptools process. I thought this might be a one line change to stop the filtering, but there's something more complicated going on, so I don't know how long it would take to investigate/fix this and we are currently working on higher priority issues (this is the only report we've seen from users using foo.bar style headers). |
Okay I see, thanks for the explanations. |
Sure. |
What is the status about the issue right now ? |
I re-tried the one-line fix I tried previously, which didn't work before, and it works now, so it should be available in 1.2.0-insiders unless we find some other problem with the change. |
Great thanks ! |
Fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/1.2.0-insiders2 We still exclude hardcoded file types that we associate with source files and don't expect or recommend being |
I tried and the issue is still there. |
You need to reload window after creating the foo.bar because our code for handling the file creation doesn't update the include completion cache unless the created file is extensionless or a known header, i.e. it's a bug -- that looks to be easy to fix for 1.3.0-insiders (I hit the bug 9 days ago, but didn't realize this was the cause (#6987)). |
The issue mentioned in my previous comment is fixed with https://github.com/microsoft/vscode-cpptools/releases/tag/1.3.0-insiders . Let us know if you notice any other bugs regarding headers with non-standard extensions. |
Type: LanguageService
Describe the bug
package-like files (ex:
MyEngine.Math.Vector3
) are not displayed in #include because they are interpreted as unrecognized extension while they don't really have extensionSteps to reproduce
type
#include <MyEngine.Math.
in a C++ file with someMyEngine.Math.Vector3
file existing in include pathExpected behavior
I want to be able to customize what files can be displayed in the #include completion. In my case I have extension-less package-like files that contains c++ code but have not a recognized extension (ex :
MyEngine.Math.Vector3
)I'm expecting an option that allows me to filter files being displayed in
#include
completion because C++ preprocessor has no constraints relative to file extensions in#include
directivesThe text was updated successfully, but these errors were encountered: