Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS property "appearance" is not supported #22

Closed
terrierscript opened this issue Feb 13, 2017 · 16 comments
Closed

CSS property "appearance" is not supported #22

terrierscript opened this issue Feb 13, 2017 · 16 comments
Labels
feature-request Request for new features or functionality
Milestone

Comments

@terrierscript
Copy link

-webkit-appearance and -moz-appearance is supported
appearance property is not supported?

preview

@aeschli
Copy link
Contributor

aeschli commented May 29, 2017

appearance is not supported by most browsers yet: https://developer.mozilla.org/en-US/docs/Web/CSS/appearance

@Harry-Harrison
Copy link

Harry-Harrison commented Jul 5, 2017

Hate to be that guy, but it not being supported by "most browsers" isn't really an excuse. Especially in this modern world where everyone and their dog uses an autoprefixer or some sort.

An ideal option might be to allow overrides for such rules? The following works for me as a catchall, but it's not ideal.

"css.lint.unknownProperties": "ignore",
"scss.lint.unknownProperties": "ignore"

@praveenpuglia
Copy link
Contributor

@aeschli I don't know how but if the prefixed version of a property is supported, I think it makes sense to have the standard property in there. Not having the standard one is in a way giving devs a push to write prefixed code, which is definitely a bad thing to do when we have tools like autoprefixer.

@praveenpuglia
Copy link
Contributor

praveenpuglia commented Jul 7, 2017

One thing I realized is that the way browser.js is generated, any property that has browsers="none" in the schema xml, will be filtered out.

Here's the dilemma.

We have to write none for the standard appearance property as no browser supports it.
But we need to get the appearance property to show up fine in text editor.

Can we have an attribute like non-standard or something more meaningful, which when applied to an entry in css-schema.xml doesn't filter it out?

@aeschli - thoughts?

@aeschli
Copy link
Contributor

aeschli commented Sep 7, 2017

@praveenpuglia I'd suggest to just remove 'browsers="none" but add a comment.

@praveenpuglia
Copy link
Contributor

Will be sending a PR then!

@praveenpuglia
Copy link
Contributor

@aeschli - is the entry for appearance removed from css-schema.xml? I don't see it in that file.

@aeschli
Copy link
Contributor

aeschli commented Sep 12, 2017

@praveenpuglia I haven't removed anything. I don't think appearance ever was in there.

@praveenpuglia
Copy link
Contributor

This is urging me to think if the language service should have tiny icons to indicate properties/values that are non-standard/experimental.
Example - MDN has a flask icon indicating experimental feature.

I, however, also think that it will then have to be done for a lot of properties which just increases maintenance overhead for support data.

@praveenpuglia
Copy link
Contributor

I thought i would start working on this today. But I have bunch of doubts.
The spec - https://drafts.csswg.org/css-ui-4/#appearance-switching
defines the appearance property to have just two values. auto | none. The prefixed versions however has tons of values.

https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-appearance#Values

If we do need to include this, which the spec says isn't ready for shipping, should we do this?

@aeschli
Copy link
Contributor

aeschli commented Nov 10, 2017

We only want to add established properties, or this won't be maintainable.
If you want to add an experimental tag, I'm fine with that, and I add UI for that, but it should only happen for properties that are very close to become standard.

@praveenpuglia
Copy link
Contributor

Then I think this can stay at the very bottom of the backlog. It's way far from becoming a standard anytime soon!

@aeschli aeschli added this to the Backlog milestone Nov 24, 2017
@aeschli aeschli added the feature-request Request for new features or functionality label Nov 24, 2017
@piotr-cz
Copy link

piotr-cz commented Jan 10, 2018

Is it possible to make builtin linter ignore some part of a file like so?

button {
  appearance: none; /* csslint allow: known-properties */
}

I'm using CSS compiler which adds vendor prefixes at build, so it doesn't make sense for me add all vendor perfixed properties by hand (I'm likely to forget some)

@marchershey
Copy link

Wow.. this still hasn't been resolved yet?

@praveenpuglia
Copy link
Contributor

@aeschli can we just add the entry for appearance for now and when we have the MDN data integration by @octref we can remove that entry from there.

I think we can probably also add a "non-standard" attribute to the entry and set it to true for it. In UI, we can show a warning about the same?

@aeschli aeschli modified the milestones: Backlog, April 2018 Apr 30, 2018
@aeschli
Copy link
Contributor

aeschli commented Apr 30, 2018

appearance got added for April

@aeschli aeschli closed this as completed Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants