Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no validation in the JSON payload input box #112

Closed
v-ruizh opened this issue Aug 28, 2020 · 1 comment · Fixed by #116
Closed

There is no validation in the JSON payload input box #112

v-ruizh opened this issue Aug 28, 2020 · 1 comment · Fixed by #116
Labels
AT-CTI Issues found by internal test team enhancement Update to existing feature
Milestone

Comments

@v-ruizh
Copy link

v-ruizh commented Aug 28, 2020

OS: Win10
Build Version: 20200827.4

Repro Steps:

  1. Open a webapi project in VS Code.
  2. F1 -> Dapr: Scaffold Dapr Tasks -> .NET Core Launch (web) -> Enter a Dapr ID 'app' for the application -> Enter the port '5000'.
  3. Open the "Controllers/WeatherForecastController.cs" file.
  4. Add the following within the class definition:
[HttpPost]
public ActionResult Post([FromBody] object body)
{
  return new JsonResult(body);
}
  1. Switch to the debug tab and change the configuration to '.NET Core Launch (web) with Dapr', then F5.
  2. F1 -> Dapr: Invoke (POST) Application Method -> Enter 'WeatherForecast' with the application method -> Enter an invalid JSON payload.

Expect:
There is an error when inputting the invalid JSON payload.

Actual:
There is no validation for the JSON payload input box.
image

More Info:
There is an error in notification when invoking application method.
image

@v-ruizh v-ruizh added the AT-CTI Issues found by internal test team label Aug 28, 2020
@philliphoff
Copy link
Collaborator

@v-ruizh Agreed, while we do catch and report the error, it's not at the most convenient point (i.e. during input of the JSON).

@philliphoff philliphoff added the enhancement Update to existing feature label Aug 31, 2020
@philliphoff philliphoff added this to the 0.3.0 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT-CTI Issues found by internal test team enhancement Update to existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants