Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Scaffold Dapr tasks using existing run file #272

Closed
philliphoff opened this issue Feb 3, 2023 · 3 comments
Closed

[Enhancement] Scaffold Dapr tasks using existing run file #272

philliphoff opened this issue Feb 3, 2023 · 3 comments
Assignees
Labels
enhancement Update to existing feature

Comments

@philliphoff
Copy link
Collaborator

Dapr 1.10 adds "run flies", a way to run Dapr applications both as a group as well as to consolidate configuration (e.g. ports, component paths, etc.). Much like with Tye, run files enable a simpler way to get applications running than using the current Dapr task/config scaffolding.

If a workspace folder already has a Dapr run file when scaffolding Dapr tasks, those tasks should use the run file.

I think more discussion might be needed to determine, if no run file is present, weather a run file should be scaffolded as well as a task to use it. That's probably the case, but perhaps that's going too "all in" on run files for the moment.

@philliphoff philliphoff added the enhancement Update to existing feature label Feb 3, 2023
@IvanJobs
Copy link
Collaborator

I will look into this one.

@yukun-dong
Copy link
Contributor

yukun-dong commented May 31, 2023

Hi @philliphoff,
I want to confirm if my understanding is correct. If the work space already has a "dapr.yaml" file, the using "Dapr: Scaffolding Dapr Tasks" command will generate the following task and configuration.
tasks.json:

        {
            "label": "dapr",
            "type": "dapr",
            "runFile": "./dapr.yaml"
        }

launch.json:

        {
            "name": "Launch Dapr",
            "request": "launch",
            "type": "dapr",
            "runFile": "${workspaceFolder}/dapr.yaml",
            "preLaunchTask": "dapr"
        }

Am I on the right track? Please let me know if there's anything else I need to consider. Thanks.

@philliphoff
Copy link
Collaborator Author

@yukun-dong Yes, I think that's what we should do. (I think we'd also want to use ${workspaceFolder}/dapr.yaml in the task as well as the configuration.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Update to existing feature
Projects
None yet
Development

No branches or pull requests

3 participants