-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Infer dapr.yaml
when omitted from configuration
#284
Comments
@MregXN You can investigate on this one first. |
Hi, @philliphoff. Is that mean the local dapr.yaml file should be read by this extension and properties in this file needs to be filled in task.json and launch.json? |
No, the suggestion is that, if the |
Hi, @philliphoff. I wanna confirm my understanding is correct with following code snippet. tasks.json: {
"label": "dapr",
"type": "dapr",
// "runFile": "./dapr.yaml"
} launch.json: {
"name": "Launch Dapr",
"request": "launch",
"type": "dapr",
//"runFile": "${workspaceFolder}/dapr.yaml",
"preLaunchTask": "dapr"
} If users do not specify a runFile (e.g., it is commented out in the code snippet), but task and launch configurations of type "dapr" still exist, extension should automatically use the dapr.yaml in the workspace without modifying these two json files. Is this right? |
Correct, there is no need to modify the configuration files; the extension should just assume use of the run file in the workspace (when it actually invokes the task/launch). Thinking about this more, there may be a subtlety here in that we should probably make this assumption only when no other properties are specified. For example, make the assumption in this case (because there's no properties that would otherwise be placed in a run file): {
"dapr": "dapr",
"type": "dapr"
} But not in this case (because the app ID is specified, indicating an explicit configuration of an app) {
"dapr": "dapr",
"type": "dapr",
"appId": "my-app"
} |
Closed with #300. |
If a Dapr task definition or debug launch configuration has been defined without an explicit run file, infer the
dapr.yaml
at the root of the workspace (if present). This will make creation/scaffolding of such configuration files simpler.The text was updated successfully, but these errors were encountered: