Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove location data from telemetry events #55

Closed
aeisenberg opened this issue Oct 13, 2020 · 2 comments · Fixed by #93
Closed

Add option to remove location data from telemetry events #55

aeisenberg opened this issue Oct 13, 2020 · 2 comments · Fixed by #93

Comments

@aeisenberg
Copy link
Contributor

For our extension, we want to gather as little information as we can about our users while still being able to answer the questions we have.

With this in mind, we do not need any location data. I would like to add an option to remove this from the payload. I can see several possible solutions:

  1. add a new flag to disable collecting location data (easy for users, but not very flexible if users also want to void sending other data, like client IP).
  2. expose the internal applicationInsight instance and allow users to customize in any way they want.
  3. Allow users to add custom TelemetryProcessors to the applicationInsight instance.

Any of these solutions would be fine by me.

@sbatten
Copy link
Member

sbatten commented Oct 20, 2020

good thought! isn't client ip already being dropped by appinsights?

@aeisenberg
Copy link
Contributor Author

Client IP was actually a bad example on my part. It looks like the applicationInsight has no control over collecting the IP as far as I can tell. I'm guessing the client IP is somehow extracted from the header of the HTTP request to azure. Though, I'm not exactly sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants