Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column Width breaks when empty/null #337

Closed
KRN-8 opened this issue Feb 7, 2022 · 1 comment
Closed

Column Width breaks when empty/null #337

KRN-8 opened this issue Feb 7, 2022 · 1 comment

Comments

@KRN-8
Copy link

KRN-8 commented Feb 7, 2022

Sorry im sleepy & lazy + ENglish not my main language => Story time:
When you click the top left cog icon you get "Bytes per row" setting. If you change it, the changes reflect ASAP (which is nice, but).
If you for example put "0" everything still works and the settings cog is still present, but if you want to write lets say "32" you would normally backspace/delete the current "16" (prolly default value) soo you could write anything else. But since changes happen immidiatley it sends "" making the internal value "hexeditor.columnWidth": "null" which breaks the whole thing and it gets stuck in loading, which makes the cog icon for changing this setting unavailable.

Workaround:
Go into VSC Settings>Extensions>Hex editor>Collumn width, where you can reset this setting or edit the .json it self.

TLDR:
you can set "hexeditor.columnWidth" setting to "null" by using hex editors GUI cog icon and emptying the "Bytes per row" field (probably missing a parse that puts 0 when empty string received)
obrazek

@lramos15
Copy link
Member

Nice find it seems that max and min don't matter to the input and deleting it causes some weird behavior. This will be fixed in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants