Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built in ipynb serializer to convert NotebookData to ipynb #15380

Closed
Tracked by #205637
DonJayamanne opened this issue Mar 18, 2024 · 1 comment · Fixed by #15383
Closed
Tracked by #205637

Use built in ipynb serializer to convert NotebookData to ipynb #15380

DonJayamanne opened this issue Mar 18, 2024 · 1 comment · Fixed by #15383
Assignees
Labels
debt Code quality issues on-testplan
Milestone

Comments

@DonJayamanne
Copy link
Contributor

This prevents having to carry ICell around,
as we end up having to expose Jupyter cell types around.
Simpler and better to use the NoetbookCellData instead

For microsoft/vscode#205637

@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Mar 18, 2024
@DonJayamanne DonJayamanne self-assigned this Mar 18, 2024
@DonJayamanne DonJayamanne added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Mar 18, 2024
@DonJayamanne DonJayamanne changed the title Drop ICell in favour of NotebookCellData Drop ICell in favour of NotebookCellData and built in ipynb serializer to convert NotebookData to ipynb JSON Mar 18, 2024
@DonJayamanne
Copy link
Contributor Author

Consider using an extension point from ipynb provider,
We already have a methdo exportNotebook, created 3 years ago, we shoudl use that
That would result in less code duplication for genrating ipynb from a list of Cells.

@DonJayamanne DonJayamanne changed the title Drop ICell in favour of NotebookCellData and built in ipynb serializer to convert NotebookData to ipynb JSON Use built in ipynb serializer to convert NotebookData to ipynb Mar 18, 2024
@DonJayamanne DonJayamanne added this to the March 2024 milestone Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant