-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking deleted files from a folder which is deleted #1317
Comments
According to #141 (comment) , the behaviour should be to only notify that the folder has been deleted in all cases. So this has regressed now it seems. The language client should try to protect against inconsistent behaviour across different platforms. |
@bpasero I get these events 1:1 from VS Code. Is this expected? |
Yes, it is expected that we do not send out delete events for each entry of a folder because listeners can easily figure out if a path is a child of said path and we can reduce the amount of events we have to send around: However, we rely on the operating system to give us the actual file events and our normalization of events works by accumulating events over some short period. If the OS gives us events slowly, above the threshold, we might start to send out individual deletes because we cannot find a common ancestor. File events can be logged when you run |
I am receiving no event(s) at all after deleting a directory containing FileSystemWatcher(
glob_pattern="**/*.sol",
kind=None,
), Is this an expected behavior? My VS Code setup:
|
As @bpasero pointed out we only send out events for the folder when a folder gets deleted. So you need to register for folder deletions as well. |
We have a language server which need to track deleted files (//*.html files)
To do that we use
workspace/didChangeWatchedFiles
which is working great when user delete html files.The problem comes from when a folder which contains html files are deleted.
My first question is it an expected behavior (I mean a different behavior between 2 OS) ?
I discover the workspace/didDeleteFiles notification, what is the difference from the workspace/didChangeWatchedFiles
Many thanks for your clarification!
The text was updated successfully, but these errors were encountered: