Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support isAI property on CodeAction #1555

Open
StellaHuang95 opened this issue Sep 6, 2024 · 2 comments
Open

Support isAI property on CodeAction #1555

StellaHuang95 opened this issue Sep 6, 2024 · 2 comments
Labels
feature-request Request for new features or functionality
Milestone

Comments

@StellaHuang95
Copy link

The Typescript team has added Copilot suggestions to various refactors in VS Code. To bring similar functionality to python code, Pylance has enabled the implement inherited abstract classes with Copilot code action through the Github Copilot extension for Python files.

To display the sparkle icon for the code action instead of the regular light bulb icon, the isAI property needs to be set to true on the codeAction.

Image

LSP doesn't support this API yet. Would it be possible for LSP to support the codeActionAI proposed API?

Is it as simple as adding the conversion logic to asCodeAction in protocolConverter.js? I'd be happy to send a PR if that's all it takes. Thanks!

@dbaeumer
Copy link
Member

dbaeumer commented Sep 9, 2024

There is actually more to it:

Happy to help if you want to work on a PR for here and https://github.com/microsoft/language-server-protocol

@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Sep 9, 2024
@dbaeumer dbaeumer added this to the On Deck milestone Sep 9, 2024
@StellaHuang95
Copy link
Author

@dbaeumer I sent both PRs, let me know if you have any feedback. Thanks for the help😊

PRs are at:
#1557
microsoft/language-server-protocol#2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants