Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Simplify generated launch.json #185

Closed
isidorn opened this issue Nov 20, 2018 · 3 comments
Closed

Simplify generated launch.json #185

isidorn opened this issue Nov 20, 2018 · 3 comments
Assignees

Comments

@isidorn
Copy link
Collaborator

isidorn commented Nov 20, 2018

This milestone we are looking into simplifing generated launch.json for various extensions microsoft/vscode#62851
Due to that I decided to create an issue also for node, for discussion and transperency.

Currently we generate the following launch.json:

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Program",
            "program": "${file}"
        }
    ]
}

We are sometimes smarter and generate a one for ts, or by looking at main and figuring out the program

{
	// Use IntelliSense to learn about possible attributes.
	// Hover to view descriptions of existing attributes.
	// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
	"version": "0.2.0",
	"configurations": [
		{
			"type": "node",
			"request": "launch",
			"name": "Launch Program",
			"program": "${workspaceFolder}/out/main",
			"outFiles": [
				"${workspaceFolder}/**/*.js"
			]
		}
	]
}

I personally like this experience and not sure how much we could further simplify this.
We could potentially add a quick pick to ask launch / attach but imho that would only overcomplicate things.

@auchenberg @weinand @roblourens let me know what you think

@roblourens
Copy link
Member

Yeah I don't think this can be simplified any more.

@auchenberg
Copy link

I agree. Our most simple debug story for Node is auto attach from the integrated terminal.

@isidorn
Copy link
Collaborator Author

isidorn commented Nov 21, 2018

Than it is fine for me to close this issue.
Though leaving that up to @weinand

@weinand weinand closed this as completed Nov 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants