Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support virtual workspaces #2722

Closed
lszomoru opened this issue May 7, 2021 · 7 comments
Closed

Support virtual workspaces #2722

lszomoru opened this issue May 7, 2021 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

lszomoru commented May 7, 2021

👋 Hi there, Martin here, from the VS Code team.

Recently we've announced the Remote Repository feature that lets you browse and edit files and folders directly on GitHub.

Open Remote Repository... opens VSCode on a folder or workspace located on a virtual file system. We call this a virtual workspace. We observed that not all extension support this well, either because they can not, or they haven't thought about it.

It would be fantastic if you could test whether your extension can handle virtual workspaces:

Check out the Virtual Workspaces Extension Author Guide on how to do that.

When done, set the new virtualWorkspaces capability in your 'package.json'.

{
  "capabilities": {
    "virtualWorkspaces": true | false
  }
}
  • Use "virtualWorkspaces": true if your extension is prepared for virtual workspaces
  • Use "virtualWorkspaces": false if your extension should be disabled when a virtual workspace is opened

For questions and comments please use the Virtual Workspaces Tracking Issue.

Thanks for the support and the great work! ❤️

@RMacfarlane RMacfarlane added the feature-request Request for new features or functionality label May 12, 2021
@alexr00 alexr00 added this to the May 2021 milestone May 17, 2021
@alexr00 alexr00 self-assigned this May 17, 2021
@alexr00 alexr00 modified the milestones: May 2021, June 2021 May 31, 2021
@egamma egamma mentioned this issue Jun 14, 2021
7 tasks
@alexr00
Copy link
Member

alexr00 commented Jun 28, 2021

Not everything is supported yet, so there's no need to test exhaustively since I already know some things are not yet working, but you should be able to:

  • View and comment on a not-checked out PR
  • View and comment on a checked out PR
  • Start working on an issue from the issues view.

@alexr00 alexr00 added the verification-needed Verification of issue is requested label Jun 28, 2021
@connor4312 connor4312 added the verified Verification succeeded label Jun 30, 2021
@connor4312
Copy link
Member

Unable to verify due to https://github.com/microsoft/vscode-remotehub/issues/40, someone else may have better luck

@connor4312 connor4312 removed the verified Verification succeeded label Jun 30, 2021
@TylerLeonhardt
Copy link
Member

My understanding is that you need the virtual workspace of the repo opened. So have main branch opened of Microsoft/vscode.

Then it's like:

  • View and comment on a not-checked out PR - totally using the PR view
  • View and comment on a checked out PR - using the PR view and looking through the actual source
  • Start working on an issue from the issues view - make sure checking out an issue from a remote workspace works

@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jun 30, 2021
@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jun 30, 2021

@alexr00 the comments don't appear in the file when I check out a PR:
image

On the left is the editor from the GHPR extension. On the right is the normal Remote Repositories editor

The other scenarios seem to work well.

@TylerLeonhardt TylerLeonhardt added verification-found Issue verification failed and removed verified Verification succeeded labels Jun 30, 2021
@alexr00
Copy link
Member

alexr00 commented Jul 1, 2021

@TylerLeonhardt thanks for testing this! I'm not able to repro what you're seeing. Are you using the nightly/insiders version of GHPRI?

@alexr00 alexr00 modified the milestones: June 2021, July 2021 Jul 1, 2021
@TylerLeonhardt
Copy link
Member

unfortunately, this still repros for me
image

image
image

@stuartleeks
Copy link

Comments are showing inline in the source for me with Remote-Repositories and the PR checked out (Nightly build v2021.7.39424):

image

Successfully viewed and commented on both checked out and non-checked out PRs.
Also checked out an issue from the issues view.

@stuartleeks stuartleeks added the verified Verification succeeded label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants