Strange avatar is displayed for GitHub Enterprise

[think120]

• Extension version: v0.27.0
• VSCode Version: Code 1.57.0
• OS: Win10 1909
• GitHub Enterprise version: GitHub Enterprise Server 3.0.4

The avatar of the Pull Request in GitHub Enterprise is strange in "GitHub" and "GitHub Pull Request" tab, as shown in the picture below:

Looks like it is because in the following postion, this.pullRequestModel.userAvatarUri is used instead of new vscode.ThemeIcon('github')

vscode-pull-request-github/src/view/treeNodes/pullRequestNode.ts

Lines 266 to 269 in 565d4e6

	iconPath: this.pullRequestModel.userAvatarUri
	? this.pullRequestModel.userAvatarUri
	: new vscode.ThemeIcon('github'),
	};

[alexr00]

@think120 I made some changes that may fix this issue this week. Would you be willing to try the nightly build of this extension (id is github.vscode-pull-request-github-insiders)? You'll need to disable the stable extension to use the nightly build.

[think120]

@alexr00 , I've tested the nightly build,

1. "GitHub" tab now can display correct avatar
   

2. For "GitHub Pull Request" tab, still shows the strange avatar
   

3. In the Pull Request Description page:

• For the Pull Request created by myself, sill shows the strange avatar
  

• For For the PR created by other people, correct avatar is displayed.
  

[alexr00]

Thanks for testing this @think120. I've found the source of the bug for the other avatar locations. There will be a new nightly build on Monday. If you could test again with that upcoming build and comment back here about whether the bug is fixed that would be very helpful!

[think120]

@alexr00, I've upgraded the nightly build of this extension to v2021.6.19263, but the issue 2 and 3 still exist. Does that build include your fix? Many thanks!

I've done some additional test in the "Pull Request Description" page, as shown in the picture below:
1 and 2 are commits, which show the weird avatar.
3 is "merge the pull request" which shows the correct avatar
4 is "delete the branch", which can't show any avatar

[alexr00]

Yes, that build has (what I thought would be) the fix. Thanks for testing this out.

[think120]

@alexr00 , many thanks for your quick fix! Now, only the "delete branch" operation can't display the avatar of the user, but it is good enough for me!

Also noticed the avatar for the user left a comment also can't be displayed.

[alexr00]

@think120 It's not clear to me what could be causing that last one, since based on your other images I would expect either the weird avatar or the correct avatar. I'm going to leave this as is for now since I don't have an enterprise setup to test with. Thank you for all your testing!

[think120]

@alexr00 , I just found this issue #416, looks like #416 has the same problem as I have.

[kabel]

The weird avatars were a purposeful fallback choice for the enterprise integration. The icon was generated from the Gravatar service since unauthenticated requests to the GHE avatar service is likely disabled for most. If your GHE email didn't exist in the Gravatar service, the default was set to the "retro" generated default.

Perhaps I should have implemented this feature behind a feature flag, but now we've regressed back to having no avatars for enterprise, which make me sad.

[kabel]

I've also seen the 404 image shown in example 4. These usually come from DOM updates to the webview instead of a full refresh, so some action is inserting a DOM image node that likely assumes a GitHub.com repo instead of GHE.

[think120]

And that 404 image is only for "delete branch" operation.

[alexr00]

@kabel are you saying that even for enterprise users who have an avatar we now show the wrong thing? If that's the case, I'll just revert the changes I made, call it a day, and not touch enterprise again.

[think120]

@kabel , @alexr00, I think may be better to make the feature of using Gravatar configurable. Like in my company, no one use Gravatar and I don't think they will use company email to register Gravatar. And I think the default octocat icon is nicer than the green "retro" icon 😄

[kabel]

@alexr00

are you saying that even for enterprise users who have an avatar we now show the wrong thing?

Yes.

0.27.1:

0.28.0:

---

@think120

And that 404 image is only for "delete branch" operation.

Not only, but certainly one of the instances of the webview templates making the wrong assumption about the avatar URL to use. Another example is when I add a reviewer or the rendered PR comments on the Description view:

I think may be better to make the feature of using Gravatar configurable.

I agree, so I'll see if I can implement that feature (for the privacy conscious and anti-gravatar folks). I had originally planned to use the SVG icon as the Gravatar fallback instead of the "retro", but couldn't find a publicly hosted version that their proxies could access.

[think120]

@kabel ,

vscode-pull-request-github/webviews/components/user.tsx

Lines 10 to 17 in 8870a3c

	export const Avatar = ({ for: author }: { for: Partial<PullRequest['author']> }) => (
	<a className="avatar-link" href={author.url}>
	{author.avatarUrl ? (
	<img className="avatar" src={author.avatarUrl} alt="" />
	) : (
	<Icon className="avatar-icon" src={require('../../resources/icons/dark/github.svg')} />
	)}
	</a>

This part?

[alexr00]

@kabel sorry about the enterprise avatar regression, and thank you for your interest in making Gravatar use configurable. I would love to accept a PR for that.