Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User hover shows null when writing the @username #4891

Closed
SKPG-Tech opened this issue Jun 5, 2023 · 1 comment · Fixed by #4892
Closed

User hover shows null when writing the @username #4891

SKPG-Tech opened this issue Jun 5, 2023 · 1 comment · Fixed by #4892
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@SKPG-Tech
Copy link
Contributor

SKPG-Tech commented Jun 5, 2023

When writing the username of someone that doesn't have a name, just a username, the user hover will show null in place of the name.
image

I happen to look at the code and notice that in the userHoverProvider it doesn't show the hover if the user doesn't have a name, maybe it could still show the hover just replace the null with a space

@alexr00 alexr00 self-assigned this Jun 7, 2023
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jun 7, 2023
@alexr00 alexr00 added this to the June 2023 milestone Jun 7, 2023
@meganrogge meganrogge added the verified Verification succeeded label Jun 28, 2023
@meganrogge
Copy link
Contributor

verified via code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants