Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles not showing up in description page for high contrast theme #897

Closed
Tyriar opened this issue Jan 30, 2019 · 1 comment
Closed

Styles not showing up in description page for high contrast theme #897

Tyriar opened this issue Jan 30, 2019 · 1 comment
Labels
accessibility bug Issue identified by VS Code Team member as probable bug description page

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 30, 2019

microsoft/vscode#67509

The first time I viewed it, it was like this:

image

The next:

image

I am seeing this in the console so it could be related:

ERR Cannot read property 'prNumber' of undefined: TypeError: Cannot read property 'prNumber' of undefined
    at c.<anonymous> (/home/daniel/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.30.0/media/extension.js:1:258479)
    at Generator.next (<anonymous>)
    at n (/home/daniel/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.30.0/media/extension.js:1:256528)
    at new Promise (<anonymous>)
    at n (/home/daniel/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.30.0/media/extension.js:1:256305)
    at c.update (/home/daniel/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.30.0/media/extension.js:1:258294)
    at constructor._panel.onDidChangeViewState.e (/home/daniel/.vscode-insiders/extensions/github.vscode-pull-request-github-insiders-1.30.0/media/extension.js:1:257083)
    at e.fire (/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:133)
    at e.$onDidChangeWebviewPanelViewState (/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:628:204)
    at t._doInvokeHandler (/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:644:118)
    at t._invokeHandler (/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:643:744)
    at t._receiveRequest (/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:642:322)
    at t._receiveOneMessage (/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:641:155)
    at /usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:638:960
    at /usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:38:994
    at e.fire (/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44:113)
    at a (/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:170:213)
    at Socket.f._socketDataListener (/usr/share/code-insiders/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:170:434)
    at Socket.emit (events.js:182:13)
    at addChunk (_stream_readable.js:279:12)
    at readableAddChunk (_stream_readable.js:264:11)
    at Socket.Readable.push (_stream_readable.js:219:10)
    at Pipe.onread (net.js:636:20)

Output:

[Info] /home/daniel/.ssh/config: ENOENT: no such file or directory, open '/home/daniel/.ssh/config'
[Info] Looking for git repository
[Info] Git repository found, initializing review manager and pr tree view.
[Info] No GitHub remotes found
[Info] Review> no matching pull request metadata found for current branch master
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch master
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch master
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch master
[Info] GitHubRepository> The remote branch for this PR was already deleted.
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch i_was_here
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch i_was_here
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch i_was_here
[Info] GitHubRepository> The remote branch for this PR was already deleted.
[Info] PullRequestGitHelper> associate i_was_here with Pull Request #50
[Info] Found GitHub remote
[Info] Review> current branch i_was_here is associated with pull request #50
[Info] Review> {"message":"Not Found","documentation_url":"https://developer.github.com/v3/repos/commits/#compare-two-commits"}
[Info] Review> register comments provider
[Info] Review> display pull request status bar indicator and refresh pull request tree view.
[Info] GitHubRepository> The remote branch for this PR was already deleted.
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch master
[Info] GitHubRepository> The remote branch for this PR was already deleted.
@Tyriar
Copy link
Member Author

Tyriar commented Jan 30, 2019

Also syntax coloring and monospace fonts aren't working in the diff above

@RMacfarlane RMacfarlane added description page accessibility bug Issue identified by VS Code Team member as probable bug labels Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Issue identified by VS Code Team member as probable bug description page
Projects
None yet
Development

No branches or pull requests

2 participants