Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace walkthrough screenshots with SVGs #16811

Closed
lszomoru opened this issue Jul 29, 2021 · 6 comments
Closed

Replace walkthrough screenshots with SVGs #16811

lszomoru opened this issue Jul 29, 2021 · 6 comments
Assignees
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@lszomoru
Copy link
Member

Testing #16796
Run and debug screenshot does not honour the current theme:

image

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jul 29, 2021
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug needs PR area-editor-* User-facing catch-all and removed triage-needed Needs assignment to the proper sub-team labels Jul 29, 2021
@luabud
Copy link
Member

luabud commented Jul 29, 2021

@digitarald Do you know if we can we define different markdown files per theme? Or have some custom logic in the markdown file to display a different image depending on the theme?

@JacksonKearl
Copy link

The best solution is using SVG's with color variables to adjust to the specific theme. Absent that, we don't currently have a way to swap out markdown images based on theme. While we support it for plain images, it tends to increase development and maintenance burden (you need to create and update three different images per step), with less impact than the SVGs as there's still only light/dark to pick from rather than theme specific coloring. If you think it's important I can look into a way to select images based on color.

@brettcannon
Copy link
Member

I think this can be considered a rough edge for now until we get time to request SVGs be made for us.

@brettcannon brettcannon removed their assignment Aug 6, 2021
@lychung7
Copy link

media.zip

@luabud I've attached the three SVGs for Select a Python Interpreter, Run and Debug, and Learn More!

@luabud
Copy link
Member

luabud commented Sep 1, 2021

@lydiayschung thank you so much Lydia!!! 🤩

@luabud luabud changed the title Python - getting started - run and debug screenshot Replace walkthrough screenshots with SVGs Sep 1, 2021
@luabud luabud added this to the September 2021 milestone Sep 1, 2021
@luabud
Copy link
Member

luabud commented Sep 28, 2021

Closing as now our walkthrough has SVGs that honor the theme.

@luabud luabud closed this as completed Sep 28, 2021
@lramos15 lramos15 added the verified Verification succeeded label Sep 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants